Page MenuHomeSoftware Heritage

deposit.settings.production: Remove the logging django configuration
ClosedPublic

Authored by ardumont on Thu, Nov 12, 3:17 PM.

Details

Summary

It prevents actual logging instructions to work. Also, it's the uwsgi
application gunicorn which is currently configured for that.

Related to T2626

Test Plan

tox

within docker (with the right docker-compose.override.yml), everything is fine.

swh-deposit_1                   | [2020-11-12 14:46:07 +0000] [75] [DEBUG] GET /1/servicedocument/
swh-deposit_1                   | [2020-11-12 14:46:07 +0000] [75] [DEBUG] Closing connection.
swh-deposit_1                   | [2020-11-12 14:46:07 +0000] [76] [DEBUG] POST /1/test/
swh-scheduler_1                 | [2020-11-12 14:46:08 +0000] [83] [DEBUG] POST /task/create
swh-deposit_1                   | [2020-11-12 14:46:08 +0000] [76] [DEBUG] Closing connection.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Nov 12, 3:17 PM
olasd accepted this revision.Thu, Nov 12, 3:19 PM
olasd added a subscriber: olasd.

I'm pretty sure we're not using Django 1.10 anymore, but that works.

This revision is now accepted and ready to land.Thu, Nov 12, 3:19 PM

Build is green

Patch application report for D4465 (id=15846)

Rebasing onto 125c4831b4...

Current branch diff-target is up to date.
Changes applied before test
commit 049fc519962d8dee97d5769c8d7cfdfcc8e99223
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 12 15:15:32 2020 +0100

    deposit.settings.production: Remove the logging django configuration
    
    It prevents actual logging instructions to work. Also, it's the uwsgi
    application gunicorn which is currently configured for that.
    
    Related to T2626

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/324/ for more details.

ardumont updated this revision to Diff 15849.Thu, Nov 12, 3:23 PM
  • Fix url to current version used
  • rework commit sentence phrasing

Build is green

Patch application report for D4465 (id=15849)

Rebasing onto 125c4831b4...

Current branch diff-target is up to date.
Changes applied before test
commit 4d7d80c1b8b725269b82856e7711585ebb6446b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Nov 12 15:15:32 2020 +0100

    deposit.settings.production: Remove the logging django configuration
    
    It prevents actual logging instructions to actually display anything.
    
    Also, currently, it's the uwsgi application gunicorn which is currently
    in charge and configured for logging.
    
    Related to T2626

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/325/ for more details.

ardumont edited the test plan for this revision. (Show Details)Thu, Nov 12, 3:35 PM
ardumont edited the test plan for this revision. (Show Details)Thu, Nov 12, 3:44 PM