Page MenuHomeSoftware Heritage

Remove the <client> tag from the protocol.
ClosedPublic

Authored by vlorentz on Thu, Nov 12, 3:01 PM.

Details

Summary

It didn't match the Atom specification, and isn't used anywhere.

Second half of the resolution of T2766.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Thu, Nov 12, 3:01 PM

Build is green

Patch application report for D4464 (id=15844)

Could not rebase; Attempt merge onto 125c4831b4...

Updating 125c4831..a85b22ca
Fast-forward
 docs/endpoints/content.rst                         |  2 --
 docs/metadata.rst                                  |  9 ------
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 --
 docs/specs/spec-sparse-deposit.rst                 |  2 --
 docs/user-manual.rst                               |  2 --
 swh/deposit/api/common.py                          | 16 +++++++++--
 swh/deposit/tests/api/test_deposit.py              |  6 ++--
 swh/deposit/tests/api/test_deposit_atom.py         | 33 ++++++++++++++++++----
 swh/deposit/tests/api/test_deposit_update.py       | 12 +++-----
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 --
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 --
 .../data/atom/error-with-external-identifier.xml   |  6 ++++
 swh/deposit/tests/data/atom/metadata.xml           |  2 --
 21 files changed, 56 insertions(+), 52 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
Changes applied before test
commit a85b22ca7e5f3e2e47c3b06b4ea323bb830f1565
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 4793f2ef85561d473a0b9932367b40d4a449ae7f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/323/ for more details.

ardumont added subscribers: moranegg, ardumont.EditedFri, Nov 13, 9:58 AM

@moranegg do you recall why we added the client in the metadata file? ^
(i think it was checked at some point but it's no longer the case apparently)...

, and isn't used anywhere.

technically true in the deposit code.

But couldn't it be interesting to have when parsing the raw xml from the raw extrinsic metadata storage?

(i recall that's why it's in there, well at the time, to read from the deposit storage... but you grok my point)

(Also note that you could find hal-preprod currently... maybe... to distinguish from the hal client)

douardda accepted this revision.Fri, Nov 13, 2:54 PM
This revision is now accepted and ready to land.Fri, Nov 13, 2:54 PM

But couldn't it be interesting to have when parsing the raw xml from the raw extrinsic metadata storage?

No, it's not checked by the deposit server, so it's useless to certify provenance.

Build has FAILED

Patch application report for D4464 (id=16169)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..164a44c9
Fast-forward
 docs/metadata.rst                                  |  9 ------
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 --
 docs/specs/spec-sparse-deposit.rst                 |  2 --
 docs/user-manual.rst                               |  2 --
 swh/deposit/api/common.py                          | 15 +++-------
 swh/deposit/tests/api/test_collection.py           |  6 ++--
 swh/deposit/tests/api/test_collection_post_atom.py | 33 ++++++++++++++++++----
 swh/deposit/tests/api/test_deposit_update.py       | 12 +++-----
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 --
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 --
 .../data/atom/error-with-external-identifier.xml   |  6 ++++
 swh/deposit/tests/data/atom/metadata.xml           |  2 --
 20 files changed, 47 insertions(+), 58 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
Changes applied before test
commit 164a44c900efeb1875e155f367123e93befc8aac
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit c5f89f7eb1e6e47d11f550a64e1d184036bb0ff6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/417/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/417/console

Build is green

Patch application report for D4464 (id=16172)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..0e3f4cf1
Fast-forward
 docs/metadata.rst                                  |  9 ------
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 --
 docs/specs/spec-sparse-deposit.rst                 |  2 --
 docs/user-manual.rst                               |  2 --
 swh/deposit/api/common.py                          | 27 ++++++++++--------
 swh/deposit/tests/api/test_collection.py           |  6 ++--
 swh/deposit/tests/api/test_collection_post_atom.py | 33 ++++++++++++++++++----
 swh/deposit/tests/api/test_deposit_update.py       | 12 +++-----
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 --
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 --
 .../data/atom/error-with-external-identifier.xml   |  6 ++++
 swh/deposit/tests/data/atom/metadata.xml           |  2 --
 20 files changed, 59 insertions(+), 58 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
Changes applied before test
commit 0e3f4cf167801e38eaed0c2d9a1e213c9f440c55
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 4f51deebc413fcaac23730d4f3521ed2293f7f08
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/420/ for more details.

Build is green

Patch application report for D4464 (id=16176)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..cbc3d115
Fast-forward
 docs/metadata.rst                                  |  9 ------
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 --
 docs/specs/spec-sparse-deposit.rst                 |  2 --
 docs/user-manual.rst                               |  2 --
 swh/deposit/api/common.py                          | 25 +++++++++-------
 swh/deposit/tests/api/test_collection.py           |  6 ++--
 swh/deposit/tests/api/test_collection_post_atom.py | 33 ++++++++++++++++++----
 swh/deposit/tests/api/test_deposit_update.py       | 12 +++-----
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 --
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 --
 .../data/atom/error-with-external-identifier.xml   |  6 ++++
 swh/deposit/tests/data/atom/metadata.xml           |  2 --
 20 files changed, 58 insertions(+), 57 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
Changes applied before test
commit cbc3d11561aeafb76340ceb64e85f0d91241858c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit dcf3c6e390e00e34da5ac03469da9cf7733d758c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/423/ for more details.

Build is green

Patch application report for D4464 (id=16181)

Could not rebase; Attempt merge onto a8e86a92ee...

Updating a8e86a92..5826e1b6
Fast-forward
 docs/metadata.rst                                  |  9 ------
 docs/specs/metadata_example.xml                    |  1 -
 docs/specs/spec-loading.rst                        |  3 +-
 docs/specs/spec-meta-deposit.rst                   |  2 --
 docs/specs/spec-sparse-deposit.rst                 |  2 --
 docs/user-manual.rst                               |  2 --
 swh/deposit/api/common.py                          | 24 ++++++++++------
 swh/deposit/tests/api/test_collection.py           |  6 ++--
 swh/deposit/tests/api/test_collection_post_atom.py | 33 ++++++++++++++++++----
 swh/deposit/tests/api/test_deposit_update.py       | 12 +++-----
 swh/deposit/tests/conftest.py                      |  2 +-
 swh/deposit/tests/data/atom/codemeta-sample.xml    |  1 -
 .../entry-data-fail-metadata-functional-checks.xml |  1 -
 swh/deposit/tests/data/atom/entry-data-minimal.xml |  2 +-
 swh/deposit/tests/data/atom/entry-data0.xml        |  2 --
 swh/deposit/tests/data/atom/entry-data1.xml        |  1 -
 swh/deposit/tests/data/atom/entry-data2.xml        |  1 -
 swh/deposit/tests/data/atom/error-with-decimal.xml |  2 --
 .../data/atom/error-with-external-identifier.xml   |  6 ++++
 swh/deposit/tests/data/atom/metadata.xml           |  2 --
 20 files changed, 58 insertions(+), 56 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/error-with-external-identifier.xml
Changes applied before test
commit 5826e1b60d169b41ae984669183f7c8262d6c260
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 15:01:38 2020 +0100

    Remove the <client> tag from the protocol.
    
    It didn't match the Atom specification, and isn't used anywhere.

commit 78befb03cfd9c7b423b7e23b6ecd5580d0699941
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 12 14:47:09 2020 +0100

    Remove the <external_identifier> tag from the protocol.
    
    It didn't match the Atom specification, duplicates the Slug header,
    while being optional and specified as 'SHOULD match the Slug'.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/426/ for more details.

This revision was automatically updated to reflect the committed changes.