Differential D4446

common/archive: Fix lookup_missing_hashes for releases and snapshots
ClosedPublic
Actions

Authored by anlambert on Nov 9 2020, 12:05 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2763: Web API: /known return false for existing release and snapshot SWHIDs

Commits

rDWAPPS3a64edd8360c: common/archive: Fix lookup_missing_hashes for releases and snapshots

Summary

Wrong storage methods were called for these object types leading to invalid result.

Closes T2763

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 9 2020, 12:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 9 2020, 12:05 PM

ardumont accepted this revision.Nov 9 2020, 12:08 PM

This revision is now accepted and ready to land.Nov 9 2020, 12:08 PM

Build is green

Patch application report for D4446 (id=15739)

Rebasing onto 1fe4ad7bc0...

Current branch diff-target is up to date.

Changes applied before test

commit 3a64edd8360cdc138928a488b284b6bd5830192e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Nov 9 12:03:07 2020 +0100

    common/archive: Fix lookup_missing_hashes for releases and snapshots
    
    Closes T2763

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/462/ for more details.

Harbormaster completed remote builds in B16953: Diff 15739.Nov 9 2020, 12:12 PM

Closed by commit rDWAPPS3a64edd8360c: common/archive: Fix lookup_missing_hashes for releases and snapshots (authored by anlambert). · Explain WhyNov 9 2020, 12:19 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS3a64edd8360c: common/archive: Fix lookup_missing_hashes for releases and snapshots.

Revision Contents
Changeset List

Path

Size

swh/

web/

common/

archive.py

4 lines

tests/

api/

views/

test_identifiers.py

19 lines

Diff 15742

View Options

swh/web/common/archive.py