Differential D4415

algos.snapshot.snapshot_resolve_alias: Don't return the branch list.
ClosedPublic
Actions

Authored by vlorentz on Nov 5 2020, 12:08 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTO84984a600cdb: algos.snapshot.snapshot_resolve_alias: Don't return the branch list.

Summary

It complicates the signature and the code, and we don't have any use
for it currently.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16870
Build 26027: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 26026: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 5 2020, 12:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 5 2020, 12:08 PM

Build is green

Patch application report for D4415 (id=15648)

Rebasing onto fa868346c6...

Current branch diff-target is up to date.

Changes applied before test

commit 84984a600cdb2834a0a64e506e1ed28507b0a27f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Nov 5 12:08:13 2020 +0100

    algos.snapshot.snapshot_resolve_alias: Don't return the branch list.
    
    It complicates the signature and the code, and we don't have any use
    for it currently.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1050/ for more details.

Harbormaster completed remote builds in B16870: Diff 15648.Nov 5 2020, 12:29 PM

anlambert accepted this revision.Nov 5 2020, 12:35 PM

This revision is now accepted and ready to land.Nov 5 2020, 12:35 PM

Closed by commit rDSTO84984a600cdb: algos.snapshot.snapshot_resolve_alias: Don't return the branch list. (authored by vlorentz). · Explain WhyNov 5 2020, 1:03 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO84984a600cdb: algos.snapshot.snapshot_resolve_alias: Don't return the branch list..