Rename the `id` argument of raw_extrinsic_metadata_get to `target`
ClosedPublic
Actions

Authored by olasd on Nov 3 2020, 4:01 PM.

Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDSTO943e440a9f39: Rename the `id` argument of raw_extrinsic_metadata_get to `target`

Summary

Consistently with the new name for this attribute in swh.model 0.7.2.

Test Plan

tox + pytest in other modules using this function (requires D4404 in swh.loader.core)

Diff Detail

Repository

rDSTO Storage manager

Branch

raw-extrinsic-metadata-id-to-target

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16830
Build 25961: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25960: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 3 2020, 4:01 PM

Build is green

Patch application report for D4407 (id=15607)

Rebasing onto 48b6dbe468...

Current branch diff-target is up to date.

Changes applied before test

commit 943e440a9f390b38c91650376f2e0e6932371a07
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Nov 3 15:59:52 2020 +0100

    Rename the `id` argument of raw_extrinsic_metadata_get to `target`
    
    Consistently with the new name for this attribute in swh.model 0.7.2.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1038/ for more details.

Harbormaster completed remote builds in B16830: Diff 15607.Nov 3 2020, 4:06 PM