Differential D4404

Use positional arguments for storage.raw_extrinsic_metadata_get
ClosedPublic
Actions

Authored by olasd on Nov 3 2020, 3:29 PM.

Details

Reviewers

vlorentz

Commits

rDLDBASE447277974e7b: Use positional arguments for storage.raw_extrinsic_metadata_get

Summary

This will allow us to change the name of the id argument to target without going
through a deprecation cycle.

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 3 2020, 3:29 PM

Build is green

Patch application report for D4404 (id=15601)

Could not rebase; Attempt merge onto 8f41aeee10...

Updating 8f41aee..4472779
Fast-forward
 requirements-swh.txt                             | 2 +-
 swh/loader/package/deposit/tests/test_deposit.py | 6 +++---
 swh/loader/package/loader.py                     | 8 ++++----
 swh/loader/package/nixguix/tests/test_nixguix.py | 6 ++----
 swh/loader/package/npm/tests/test_npm.py         | 6 ++----
 swh/loader/package/pypi/tests/test_pypi.py       | 6 ++----
 swh/loader/package/tests/test_loader_metadata.py | 8 ++++----
 7 files changed, 18 insertions(+), 24 deletions(-)

Changes applied before test

commit 447277974e7ba5f400192f77b904bd47d2e1319f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Nov 3 15:27:57 2020 +0100

    Use positional arguments for storage.raw_extrinsic_metadata_get
    
    This will allow us to change the name of the id argument to target without going
    through a deprecation cycle.

commit 7f4e53aedde7b2869804192677995f852d446f8d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Nov 3 15:02:30 2020 +0100

    Use the `target` argument to RawExtrinsicMetadata instead of deprecated `id`
    
    This argument was deprecated in swh.model v0.7.2

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/338/ for more details.

Harbormaster completed remote builds in B16824: Diff 15601.Nov 3 2020, 3:31 PM

vlorentz accepted this revision.Nov 3 2020, 3:32 PM

This revision is now accepted and ready to land.Nov 3 2020, 3:32 PM

olasd mentioned this in D4407: Rename the `id` argument of raw_extrinsic_metadata_get to `target`.Nov 3 2020, 4:01 PM

Closed by commit rDLDBASE447277974e7b: Use positional arguments for storage.raw_extrinsic_metadata_get (authored by olasd). · Explain WhyNov 3 2020, 5:10 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDBASE447277974e7b: Use positional arguments for storage.raw_extrinsic_metadata_get.