Page MenuHomeSoftware Heritage

Update metadata-only deposit specification
ClosedPublic

Authored by ardumont on Nov 3 2020, 3:24 PM.

Details

Summary

This adds the requirements for now.
Planning to add the sample update next.

Related to T2541

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16822
Build 25945: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25944: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4403 (id=15598)

Rebasing onto be5fd4afe0...

Current branch diff-target is up to date.
Changes applied before test
commit 533a2c85ac769b6f9e9a299b05ab42852cf59952
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:03:09 2020 +0100

    Add metadata-only deposit specification
    
    Related to T2541

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/273/ for more details.

docs/conf.py
9

this allows internal linking in the bullet point 1. and 3. below.

ardumont retitled this revision from Add metadata-only deposit specification to Update metadata-only deposit specification.Nov 3 2020, 3:29 PM

Build is green

Patch application report for D4403 (id=15600)

Rebasing onto be5fd4afe0...

Current branch diff-target is up to date.
Changes applied before test
commit c3efb64c3348761e5e65a1a2c4e152e432183f90
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:03:09 2020 +0100

    Add metadata-only deposit specification
    
    Related to T2541

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/274/ for more details.

Looks good to me

docs/specs/spec-meta-deposit.rst
39

I thought I created a schema but I can't remember where I put it...

Maybe add create and publish SWH-deposit schema using a persistent URL (without defining in specs the actual location.
But we used this URL in the example.

What do you think?

This revision is now accepted and ready to land.Nov 3 2020, 3:32 PM
docs/specs/spec-meta-deposit.rst
39

I thought I created a schema...

T2625 ?

create and publish SWH-deposit schema using a persistent URL

yes, fine ;)

docs/specs/spec-meta-deposit.rst
39

better, given T2625 (which wants to publish said schema), the todo can go away (in another commit).

docs/specs/spec-meta-deposit.rst
39
docs/specs/spec-meta-deposit.rst
39

I agree.

In T2625 there is just an example, but in 2018 I feel like I've spent some time on that... not sure though.
And it might be obsolete with the new changes.

Build is green

Patch application report for D4403 (id=15604)

Could not rebase; Attempt merge onto be5fd4afe0...

Updating be5fd4af..8b016d4b
Fast-forward
 docs/conf.py                     |  2 ++
 docs/specs/spec-meta-deposit.rst | 30 +++++++++++++++++-------------
 2 files changed, 19 insertions(+), 13 deletions(-)
Changes applied before test
commit 8b016d4b70b5b81289d0793e52429365ebddc19e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:03:09 2020 +0100

    Update metadata-only deposit specification
    
    Related to T2541

commit d8d4e0bc9a01d9439739559ea30609946c2b998e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:39:36 2020 +0100

    Drop todo from the specification
    
    Related to T2625

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/276/ for more details.

Build is green

Patch application report for D4403 (id=15605)

Could not rebase; Attempt merge onto be5fd4afe0...

Updating be5fd4af..455d780c
Fast-forward
 docs/conf.py                     |  2 ++
 docs/specs/spec-meta-deposit.rst | 30 +++++++++++++++++-------------
 2 files changed, 19 insertions(+), 13 deletions(-)
Changes applied before test
commit 455d780c1082736913c740292e9e040adf6f67d6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:03:09 2020 +0100

    spec-meta-deposit: Update metadata-only deposit requirements
    
    Related to T2541

commit d8d4e0bc9a01d9439739559ea30609946c2b998e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Nov 3 15:39:36 2020 +0100

    Drop todo from the specification
    
    Related to T2625

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/277/ for more details.

docs/specs/spec-meta-deposit.rst
39