Details

Reviewers

None

Group Reviewers

Commits

Summary

This installs the expected output task-type the lister outputs in the scheduler.

This was partially done on some lister but not all.
This aligns everything.

Now every lister has a conftest with the required fixture.
And every lister is called after its name lister_{gnu,launchpad, ...}

Hopefully this clarifies the tests. It did for me when i was tracking down the build failures.

Test Plan

tox happy

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16736
Build 25811: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25810: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1,032 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.debian.tests.test_lister::test_lister_debian lister_debian = <swh.lister.debian.lister.DebianLister object at 0x7f23f4bf64e0> datadir = '/var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/debian/tests/data' requests_mock_datadir = <requests_mock.mocker.Mocker object at 0x7f23f4d62cf8>
	1,569 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister::test_lister_bitbucket
	2,642 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister.BitBucketListerTester::test_api_request
	597 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister.BitBucketListerTester::test_fetch_multiple_pages_nodb
	1,549 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.bitbucket.tests.test_lister.BitBucketListerTester::test_fetch_multiple_pages_yesdb
		View Full Test Results (1 Failed · 138 Passed)

Event Timeline

ardumont created this revision.Oct 29 2020, 6:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2020, 6:50 PM

Build was aborted

Patch application report for D4386 (id=15508)

Rebasing onto a19cb5fb51...

Current branch diff-target is up to date.

Changes applied before test

commit e4ff12d61afaffa18060befc8b5ac6728598de64
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit 3f4f9b964ceb768b8a872034948f11bdfbcaaf4f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit 47f1938f5023dae48ee6f4057ba42af9d1c51582
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit 8f6221c16105099d54123114d5c77aa7c2a46350
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit 83f9f18e464aef4d09e7dcec293c1886e75c7d9f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit b3045a58b1bc8c829e662d60095a8d138c0b7daa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit 55e18ac72f27da55737797b492b49d5f65d2b4f6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit 7ea46cfa5c7e0e6f61efd13d306043ef6f73f89e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    lister.debian.tests: Clarify lister configuration

commit 9703e9a9222ae3c5c190888ed77e3e0c9088579b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit e908b9f8160614338e2be9f90fdd74319ec0868b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit beba3eacdd6fc53a96a707159c8e02ebd399a47c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit 5a5bbcf51eb376f2b73f93680f3ab5f4cb2d87a9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 16:54:10 2020 +0100

    Create listing task with a default of 3 if unspecified
    
    This will allow to retry task if they do not specify it.

commit 021b0e3c272f4b0ae8afc6780ef1656e58daafba
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 21 17:41:42 2020 +0200

    lister.pytest_plugin: Reuse swh.core.db.db_utils postgresql_fact

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/56/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/56/console

Harbormaster failed remote builds in B16734: Diff 15508!Oct 29 2020, 6:58 PM

Simplify further the debian lister fixtures

ardumont planned changes to this revision.Oct 29 2020, 7:05 PM

Build was aborted

Patch application report for D4386 (id=15509)

Rebasing onto a19cb5fb51...

Current branch diff-target is up to date.

Changes applied before test

commit c70bea7e530f7d194261ac1b4de334dd6ef6bf1c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit c2d4af90f28e181233e7424ec2da8cb0726af744
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit 23bd1f46152ad06d4064c04227d9d043046aa7c0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit cd96b40f16994391e5520f6f01d9991f49c551b3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit 48f5caed39da5b567c357987ad39ff2942930aea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit bc5faefee5fdc00f1744d52963e7e973981591bb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit 0b6dbbb5adf035b3931a5e1247edf880fe2e9484
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit bdca2a31d3100282842af578638d0e900da9d2ca
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    lister.debian.tests: Simplify fixture declaration for debian lister

commit 9703e9a9222ae3c5c190888ed77e3e0c9088579b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit e908b9f8160614338e2be9f90fdd74319ec0868b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit beba3eacdd6fc53a96a707159c8e02ebd399a47c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit 5a5bbcf51eb376f2b73f93680f3ab5f4cb2d87a9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 16:54:10 2020 +0100

    Create listing task with a default of 3 if unspecified
    
    This will allow to retry task if they do not specify it.

commit 021b0e3c272f4b0ae8afc6780ef1656e58daafba
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 21 17:41:42 2020 +0200

    lister.pytest_plugin: Reuse swh.core.db.db_utils postgresql_fact

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/57/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/57/console

Harbormaster failed remote builds in B16735: Diff 15509!Oct 29 2020, 7:17 PM

Simplify fixtures (drop indirections when possible)

"iso bug" => urrent flip-flop debian lister test failure still ko [1]

[1] https://jenkins.softwareheritage.org/job/DLS/job/tests/1043/console

ardumont planned changes to this revision.Oct 29 2020, 9:39 PM

Build has FAILED

Patch application report for D4386 (id=15510)

Rebasing onto a19cb5fb51...

Current branch diff-target is up to date.

Changes applied before test

commit 814da020378d63b7deab08a29761e0064578cf70
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 20:36:40 2020 +0100

    tests: Reduce the db initialization steps to a minimum

commit b286fdf4c16e946af6c9a6657269b32b7f4afa61
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 20:03:31 2020 +0100

    lister.tests: Simplify engine fixture

commit cd8db0eb0e60f3494bb4bcf70703ff5c41fd19fe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit 96e338f0b11271e7563b2601731860ffb2e3a201
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit cbce6292442374e0cb615e2e961e8ee0c31173ac
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit 8dc8601e8e1652e867d583b3dfc6b673e7ba63eb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit cf1cd97bccb73c8f72aaf8395c157ea4bc6bdf6c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit db12d792dc29ac75f00bb03ee628eedb64463334
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit 56ebbcfa3287524e412dd3220fef6731d6763d4a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit a15d93ecb0030c486319459220d72ba45bf27a4f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    lister.debian.tests: Simplify fixture declaration for debian lister

commit 99685ec9486406484c25da8bff50479b0c5d6ac4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit d70ed3da7fbe1616dc44602018b7d4280d4b1209
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit 13a2214f75de819ef032ee9256c7f93473a6380d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit b1cbded60c359bd15eecfebf3c3d56b4c5b37f7f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 16:54:10 2020 +0100

    Create listing task with a default of 3 if unspecified
    
    This will allow to retry task if they do not specify it.

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/58/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/58/console

Harbormaster failed remote builds in B16736: Diff 15510!Oct 29 2020, 9:42 PM

Fix broken master build

needs to be splitted.

Build is green

Patch application report for D4386 (id=15511)

Rebasing onto a19cb5fb51...

Current branch diff-target is up to date.

Changes applied before test

commit 0d29e952bc7231b63bfe55f3260c7795db38a806
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit df2f4a647158e34d7c44fab197b4f1b3481ce82e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit 139717fc5c57a07cca5d8f91b6269ab552fba2f7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit 973693eb2eaa8ae957435f6730a2c117f610796e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit 284f41b41cddef35e2f6b8b7eca543dd6aef3624
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit 0add510c85ece0d241e2e0a50f5cfafc17a327d3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit 014d933f54d779af6480f7c3eb3f567f921a02d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit abb60e4064106d97c1029aeb86ad15d15a36ab58
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit e3c6a63e3ec4591c3cdd25f89b03e64585cc2b50
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit f3e80e1c9c34431ea9d4bb6e5c186f5c0f6bb298
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 22:09:32 2020 +0100

    debian.tests: Fix test
    
    The scheduler fixture introduced truncates tables in between tests. The debian
    tests unfortunately share state and it broke when that changed. This fixes the
    test by avoiding the truncation the table tasks.
    
    Ideally those tests need to be rework to avoid sharing tests.
    
    [1] https://jenkins.softwareheritage.org/job/DLS/job/tests/1043

commit 754f706e0d19abab2db8fd5d7b9d3bc2c6bdb3f5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 20:03:31 2020 +0100

    tests: Reduce db initialization fixtures to a minimum

commit 859b0d81a085ad0433a505d9f9b932fbd23ab388
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit 22778de1f0b2500b9379018f21e845df2255681d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    lister.debian.tests: Simplify fixture declaration for debian lister

commit b1cbded60c359bd15eecfebf3c3d56b4c5b37f7f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 16:54:10 2020 +0100

    Create listing task with a default of 3 if unspecified
    
    This will allow to retry task if they do not specify it.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/59/ for more details.

Harbormaster completed remote builds in B16737: Diff 15511.Oct 29 2020, 10:18 PM

ardumont edited the summary of this revision. (Show Details)Oct 29 2020, 10:18 PM

ardumont edited the summary of this revision. (Show Details)

ardumont retitled this revision from lister.pytest_plugin: Reuse swh.core.db.db_utils postgresql_fact to lister.tests: clean up.Oct 29 2020, 10:22 PM

Keep scope of this diff about expliciting the lister conftest

ardumont retitled this revision from lister.tests: clean up to lister.tests: Explicit required scheduler task-type needed for each lister.Oct 30 2020, 9:46 AM

ardumont edited the summary of this revision. (Show Details)

Build is green

Patch application report for D4386 (id=15517)

Could not rebase; Attempt merge onto b35dff1266...

Updating b35dff1..978276e
Fast-forward
 swh/lister/bitbucket/tests/conftest.py    | 32 +++++++++++++++++++++
 swh/lister/bitbucket/tests/test_lister.py | 16 +++--------
 swh/lister/cgit/tests/conftest.py         | 26 +++++++++++++++++
 swh/lister/cgit/tests/test_lister.py      | 46 ++++++++++++-------------------
 swh/lister/cran/tests/conftest.py         |  1 -
 swh/lister/cran/tests/test_lister.py      |  8 ++----
 swh/lister/debian/tests/conftest.py       | 27 +++---------------
 swh/lister/gitea/tests/conftest.py        | 26 +++++++++++++++++
 swh/lister/gitea/tests/test_lister.py     | 15 ++--------
 swh/lister/github/tests/conftest.py       | 26 +++++++++++++++++
 swh/lister/github/tests/test_lister.py    | 12 ++------
 swh/lister/gitlab/tests/conftest.py       | 26 +++++++++++++++++
 swh/lister/gitlab/tests/test_lister.py    |  6 ++--
 swh/lister/gnu/tests/conftest.py          | 26 +++++++++++++++++
 swh/lister/gnu/tests/test_lister.py       | 14 ++--------
 swh/lister/launchpad/tests/conftest.py    | 15 ++++++----
 swh/lister/npm/tests/test_lister.py       |  4 +--
 swh/lister/phabricator/tests/conftest.py  |  8 ++++++
 swh/lister/pytest_plugin.py               | 14 ++++++----
 19 files changed, 231 insertions(+), 117 deletions(-)
 create mode 100644 swh/lister/bitbucket/tests/conftest.py
 create mode 100644 swh/lister/cgit/tests/conftest.py
 create mode 100644 swh/lister/gitea/tests/conftest.py
 create mode 100644 swh/lister/github/tests/conftest.py
 create mode 100644 swh/lister/gitlab/tests/conftest.py
 create mode 100644 swh/lister/gnu/tests/conftest.py

Changes applied before test

commit 978276efbbdb79141ead7af6ac46f482b05fadbb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit 8c837a7451d9269c893b87e164eba6b63f3b9afa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit 88bd0fab1f2226967f1023cdf907b9088dfb9a3c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit 0460179086b2fd72bcacdb2b40cda674966e1cd8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit 12f9198f1e3e40e108c27fa658033521aabd3917
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit 8cae60798ca1dfe7ead22585bc66749581ce6e02
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit b9d6db757ffa173feedc0c84ddbffa373ddc7c44
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit 37a1dbcf615e86f3fb662fd6774e8ca09ceba950
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit e819d3efaa4ad8e3d6af4b91ac7bc93d21e2020d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit 1b236dde5dcebed46dd645e07a793df345a3e308
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit baa151360584979b5153fb1ed645a06512e40d1c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    tests: Reduce db initialization fixtures to a minimum

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B16743: Diff 15517.Oct 30 2020, 9:46 AM

Rebase
Drop unneeded lister_cgit = lister_cgit instruction

Build is green

Patch application report for D4386 (id=15523)

Could not rebase; Attempt merge onto b35dff1266...

Updating b35dff1..8845850
Fast-forward
 swh/lister/bitbucket/tests/conftest.py    | 32 +++++++++++++++++++++
 swh/lister/bitbucket/tests/test_lister.py | 16 +++--------
 swh/lister/cgit/tests/conftest.py         | 26 +++++++++++++++++
 swh/lister/cgit/tests/test_lister.py      | 46 +++++++++++--------------------
 swh/lister/cran/tests/conftest.py         |  1 -
 swh/lister/cran/tests/test_lister.py      |  8 ++----
 swh/lister/debian/tests/conftest.py       | 27 +++---------------
 swh/lister/gitea/tests/conftest.py        | 26 +++++++++++++++++
 swh/lister/gitea/tests/test_lister.py     | 15 ++--------
 swh/lister/github/tests/conftest.py       | 26 +++++++++++++++++
 swh/lister/github/tests/test_lister.py    | 12 ++------
 swh/lister/gitlab/tests/conftest.py       | 26 +++++++++++++++++
 swh/lister/gitlab/tests/test_lister.py    |  6 ++--
 swh/lister/gnu/tests/conftest.py          | 26 +++++++++++++++++
 swh/lister/gnu/tests/test_lister.py       | 14 ++--------
 swh/lister/launchpad/tests/conftest.py    | 14 ++++++----
 swh/lister/npm/tests/test_lister.py       |  4 +--
 swh/lister/phabricator/tests/conftest.py  |  8 ++++++
 swh/lister/pytest_plugin.py               | 14 ++++++----
 19 files changed, 229 insertions(+), 118 deletions(-)
 create mode 100644 swh/lister/bitbucket/tests/conftest.py
 create mode 100644 swh/lister/cgit/tests/conftest.py
 create mode 100644 swh/lister/gitea/tests/conftest.py
 create mode 100644 swh/lister/github/tests/conftest.py
 create mode 100644 swh/lister/gitlab/tests/conftest.py
 create mode 100644 swh/lister/gnu/tests/conftest.py

Changes applied before test

commit 884585034b3f5177307d6fefc3c41f6db718e481
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 18:38:53 2020 +0100

    lister.phabricator.tests: Add task-type related to lister

commit 243f3573bc2718c4668751a938d25cbb987f534d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:59:27 2020 +0100

    lister.npm.tests: Clarify lister configuration

commit 36bc51cec58f8a94966e600a9876116415409cd9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:54:01 2020 +0100

    lister.gnu.tests: Clarify lister configuration

commit 20a91482ca272548e99ca4bdd749906d1880700d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:50:08 2020 +0100

    lister.gitlab.tests: Clarify lister configuration

commit 978fbbe0296f8d21e94c2ea6fa854013765e8ac2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:43:22 2020 +0100

    lister.github.tests: Clarify lister configuration

commit def0eb5060795bb86f7d445056c1b5a454bd6b6f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:39:38 2020 +0100

    lister.gitea.tests: Clarify lister configuration

commit 47ccce3817aa3a97f2e9ff68d8f048e119f86652
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:31:21 2020 +0100

    lister.cran.tests: Clarify lister configuration

commit 5d4b38999d8c3877600b0d545e7971390103618c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:28:55 2020 +0100

    lister.cgit.tests: Clarify lister configuration

commit c5af0efbf43406c7f8bf17ee7b5fbbf53ae8f8e1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:23:45 2020 +0100

    lister.bitbucket.tests: Clarify lister configuration

commit f09b9f8cfa0471fc5073064bf37a610519f126b9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:57:52 2020 +0100

    lister.launchpad.tests: Clarify lister configuration

commit b90ffa4bddee9ea242ebeaa235d24e850ab13ca9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 29 17:37:45 2020 +0100

    tests: Reduce db initialization fixtures to a minimum

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/66/ for more details.

Harbormaster completed remote builds in B16750: Diff 15523.Oct 30 2020, 1:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 30 2020, 1:41 PM

Closed by commit rDLSf09b9f8cfa04: lister.launchpad.tests: Clarify lister configuration (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLSf09b9f8cfa04: lister.launchpad.tests: Clarify lister configuration.

ardumont added a commit: rDLS5d4b38999d8c: lister.cgit.tests: Clarify lister configuration.

ardumont added a commit: rDLSc5af0efbf434: lister.bitbucket.tests: Clarify lister configuration.

ardumont added a commit: rDLS47ccce3817aa: lister.cran.tests: Clarify lister configuration.

ardumont added a commit: rDLSdef0eb506079: lister.gitea.tests: Clarify lister configuration.

ardumont added a commit: rDLS978fbbe0296f: lister.github.tests: Clarify lister configuration.

ardumont added a commit: rDLS20a91482ca27: lister.gitlab.tests: Clarify lister configuration.

ardumont added a commit: rDLS36bc51cec58f: lister.gnu.tests: Clarify lister configuration.

ardumont added a commit: rDLS243f3573bc27: lister.npm.tests: Clarify lister configuration.

ardumont added a commit: rDLS884585034b3f: lister.phabricator.tests: Add task-type related to lister.

lister.tests: Explicit required scheduler task-type needed for each lister
ClosedPublic
Actions

Details

Diff Detail

Unit TestsFailed
View All

Event Timeline

Patch application report for D4386 (id=15508)

Changes applied before test

Patch application report for D4386 (id=15509)

Changes applied before test

Patch application report for D4386 (id=15510)

Changes applied before test

Patch application report for D4386 (id=15511)

Changes applied before test

Patch application report for D4386 (id=15517)

Changes applied before test

Patch application report for D4386 (id=15523)

Changes applied before test

Revision Contents
Changeset List

Diff 15510

swh/lister/bitbucket/tests/conftest.py

swh/lister/bitbucket/tests/test_lister.py

swh/lister/cgit/tests/conftest.py

swh/lister/cgit/tests/test_lister.py

swh/lister/core/lister_base.py

swh/lister/cran/tests/conftest.py

swh/lister/cran/tests/test_lister.py

swh/lister/debian/tests/conftest.py

swh/lister/gitea/tests/conftest.py

swh/lister/gitea/tests/test_lister.py

swh/lister/github/tests/conftest.py

swh/lister/github/tests/test_lister.py

swh/lister/gitlab/tests/conftest.py

swh/lister/gitlab/tests/test_lister.py

swh/lister/gnu/tests/conftest.py

swh/lister/gnu/tests/test_lister.py

swh/lister/launchpad/tests/conftest.py

swh/lister/launchpad/tests/test_lister.py

swh/lister/npm/tests/test_lister.py

swh/lister/phabricator/tests/conftest.py

swh/lister/pytest_plugin.py

lister.tests: Explicit required scheduler task-type needed for each listerClosedPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Patch application report for D4386 (id=15508)

Changes applied before test

Patch application report for D4386 (id=15509)

Changes applied before test

Patch application report for D4386 (id=15510)

Changes applied before test

Patch application report for D4386 (id=15511)

Changes applied before test

Patch application report for D4386 (id=15517)

Changes applied before test

Patch application report for D4386 (id=15523)

Changes applied before test

Revision ContentsChangeset List

Diff 15510

swh/lister/bitbucket/tests/conftest.py

swh/lister/bitbucket/tests/test_lister.py

swh/lister/cgit/tests/conftest.py

swh/lister/cgit/tests/test_lister.py

swh/lister/core/lister_base.py

swh/lister/cran/tests/conftest.py

swh/lister/cran/tests/test_lister.py

swh/lister/debian/tests/conftest.py

swh/lister/gitea/tests/conftest.py

swh/lister/gitea/tests/test_lister.py

swh/lister/github/tests/conftest.py

swh/lister/github/tests/test_lister.py

swh/lister/gitlab/tests/conftest.py

swh/lister/gitlab/tests/test_lister.py

swh/lister/gnu/tests/conftest.py

swh/lister/gnu/tests/test_lister.py

swh/lister/launchpad/tests/conftest.py

swh/lister/launchpad/tests/test_lister.py

swh/lister/npm/tests/test_lister.py

swh/lister/phabricator/tests/conftest.py

swh/lister/pytest_plugin.py

lister.tests: Explicit required scheduler task-type needed for each lister
ClosedPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List