Differential D4385

identifiers/resolve_swhid: Handle directory path without trailing slash
ClosedPublic
Actions

Authored by anlambert on Oct 29 2020, 5:45 PM.

Details

Reviewers

moranegg

Group Reviewers

Reviewers

Maniphest Tasks

T2742: Resolving a contextual SWHID with path without // at the end

Commits

rDWAPPSf6cb1561787f: identifiers/resolve_swhid: Handle directory path without trailing slash

Summary

This fixes an issue when users forgot to add a trailing slash to the URL
resolving a SWHID targetting a non root directory.

Closes T2742

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 29 2020, 5:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2020, 5:45 PM

Build is green

Patch application report for D4385 (id=15507)

Rebasing onto c72a6ba738...

Current branch diff-target is up to date.

Changes applied before test

commit f6cb1561787f24e06cfe67bc7648c1f356f91fb0
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Oct 29 17:41:19 2020 +0100

    identifiers/resolve_swhid: Handle directory path without trailing slash
    
    Closes T2742

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/443/ for more details.

Harbormaster completed remote builds in B16733: Diff 15507.Oct 29 2020, 5:53 PM

moranegg added a subscriber: moranegg.Oct 29 2020, 9:50 PM

Thanks @anlambert

This revision is now accepted and ready to land.Oct 29 2020, 10:29 PM

Closed by commit rDWAPPSf6cb1561787f: identifiers/resolve_swhid: Handle directory path without trailing slash (authored by anlambert). · Explain WhyOct 30 2020, 10:53 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSf6cb1561787f: identifiers/resolve_swhid: Handle directory path without trailing slash.

Revision Contents
Changeset List

Path

Size

swh/

web/

common/

identifiers.py

5 lines

tests/

common/

test_identifiers.py

21 lines

Diff 15520

View Options

swh/web/common/identifiers.py