Differential D4380

common/archive: Fix origin metadata functions after indexer API changes
ClosedPublic
Actions

Authored by anlambert on Oct 29 2020, 2:53 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2739: A search on metadata returns a 500

Commits

rDWAPPSc72a6ba7381f: common/archive: Fix origin metadata functions after indexer API changes

Summary

Those breaking changes were missed as related tests use mocking.

Also improve the tests by removing mocking as much as possible.

Closes T2739

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-metdata-fixes

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16718
Build 25783: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25782: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 29 2020, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 29 2020, 2:53 PM

Build is green

Patch application report for D4380 (id=15492)

Rebasing onto 3ffeb396fa...

Current branch diff-target is up to date.

Changes applied before test

commit c72a6ba7381fbcd6d59372b2462bd13af5b970ac
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Oct 29 14:49:55 2020 +0100

    common/archive: Fix origin metadata functions after indexer API changes
    
    Also improve related tests by removing mocking as much as possible.
    
    Closes T2739

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/442/ for more details.

Harbormaster completed remote builds in B16718: Diff 15492.Oct 29 2020, 3:00 PM

ardumont accepted this revision.Oct 29 2020, 3:09 PM

This revision is now accepted and ready to land.Oct 29 2020, 3:09 PM

Closed by commit rDWAPPSc72a6ba7381f: common/archive: Fix origin metadata functions after indexer API changes (authored by anlambert). · Explain WhyOct 29 2020, 5:05 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSc72a6ba7381f: common/archive: Fix origin metadata functions after indexer API changes.