Differential D4362

Update swh.storage.validate for swh.model 0.7.2
ClosedPublic
Actions

Authored by olasd on Oct 27 2020, 2:12 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDSTO581968322a47: Update swh.storage.validate for swh.model 0.7.2

Summary

swh.model.model.ModelObject.compute_hash was changed to a method instead of a
staticmethod.

Of course, now that I notice that it was used elsewhere than swh.model, this would have warranted a swh.model 0.8.0...

Test Plan

tox tests pass again

Diff Detail

Repository

rDSTO Storage manager

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16652
Build 25674: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25673: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 27 2020, 2:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 27 2020, 2:12 PM

douardda accepted this revision.Oct 27 2020, 2:17 PM

This revision is now accepted and ready to land.Oct 27 2020, 2:17 PM

Build is green

Patch application report for D4362 (id=15424)

Rebasing onto 4f35f7f928...

Current branch diff-target is up to date.

Changes applied before test

commit 581968322a47df9b3c7b137cd56328441c77e414
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Oct 27 14:09:23 2020 +0100

    Update swh.storage.validate for swh.model 0.7.2
    
    swh.model.model.ModelObject.compute_hash was changed to a method instead of a
    staticmethod.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1023/ for more details.

Harbormaster completed remote builds in B16652: Diff 15424.Oct 27 2020, 2:17 PM

Closed by commit rDSTO581968322a47: Update swh.storage.validate for swh.model 0.7.2 (authored by olasd). · Explain WhyOct 27 2020, 2:18 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO581968322a47: Update swh.storage.validate for swh.model 0.7.2.