Instead of adding a staging_new I'd probably rename the existing staging to staging_legacy, and use the staging name again for the final network, but that's really cosmetic more than anything.

data/common/common.yaml
135	spurious indent
947	this key needs to be unique (I think octocatalog-diff on pergamon will only show the addition of one of the two entries)

This revision now requires changes to proceed.Oct 21 2020, 12:02 PM

Update after the review's feedbacks

Harbormaster completed remote builds in B16511: Diff 15278.Oct 21 2020, 2:39 PM

the staging and staging_new properties were changed to staging_legacy and staging as you suggested. it's better this way.

data/common/common.yaml
135	fixed
947	good catch, it's fixed (last minute copy/paste 😊)

vsellier added a child revision: D4321: Update the network configuration of the staging nodes to use the new network range behind the firewall.Oct 21 2020, 7:32 PM

olasd accepted this revision.Oct 21 2020, 8:34 PM

This revision is now accepted and ready to land.Oct 21 2020, 8:34 PM

Closed by commit rSPSITE01aafc53af9e: Declare the opnsense firewall and the new networks it manages (authored by vsellier). · Explain WhyOct 22 2020, 10:09 AM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rSPSITE01aafc53af9e: Declare the opnsense firewall and the new networks it manages.

Revision Contents
Changeset List

Path

Size

data/

common/

common.yaml

18 lines

hostname/

pergamon.softwareheritage.org.yaml

4 lines

Diff 15265

View Options

data/common/common.yaml

View Options

data/hostname/pergamon.softwareheritage.org.yaml

Declare the opnsense firewall and the new networks it managesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15265

data/common/common.yaml

data/hostname/pergamon.softwareheritage.org.yaml

Declare the opnsense firewall and the new networks it manages
ClosedPublic
Actions

Revision Contents
Changeset List