Page MenuHomeSoftware Heritage
Differential D4294

swh.vault: Unify get_vault factory function with other factories
ClosedPublic
Actions

Authored by ardumont on Oct 16 2020, 7:33 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T1410: Kill implicit configuration: new configuration scheme
Commits
rDVAU8e4026a5e8c9: swh.vault: Unify get_vault factory function with other factories
Summary

Related to T1410

Test Plan

tox

Diff Detail

Event Timeline

ardumont created this revision.Oct 16 2020, 7:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 7:33 PM
swh-public-ci added a comment.Oct 16 2020, 7:35 PM

Build has FAILED

Patch application report for D4294 (id=15175)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..3f0225a
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit 3f0225a0585030d5fe064971164b17e940fce830
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/20/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/20/console

Harbormaster failed remote builds in B16404: Diff 15175!Oct 16 2020, 7:35 PM
ardumont edited the test plan for this revision. (Show Details)Oct 16 2020, 7:35 PM
ardumont updated this revision to Diff 15176.Oct 16 2020, 7:37 PM

Drop the requirements bump on scheduler

swh-public-ci added a comment.Oct 16 2020, 7:39 PM

Build has FAILED

Patch application report for D4294 (id=15176)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..c062d3a
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit c062d3ab7ff614bf1ebc3f69ed1de46f77258ba3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/21/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/21/console

Harbormaster failed remote builds in B16405: Diff 15176!Oct 16 2020, 7:39 PM
ardumont updated this revision to Diff 15177.Oct 16 2020, 7:44 PM

Drop properly the requirement on swh-scheduler.

swh-public-ci added a comment.Oct 16 2020, 7:45 PM

Build is green

Patch application report for D4294 (id=15177)

Could not rebase; Attempt merge onto a8fa57718b...

Updating a8fa577..efd5eb4
Fast-forward
 requirements-test.txt        |  1 +
 swh/vault/__init__.py        | 53 ++++++++++++++++++++++++++----------------
 swh/vault/api/server.py      |  7 ++----
 swh/vault/backend.py         | 13 +++++++----
 swh/vault/tests/conftest.py  | 46 ++++++++++++++++++------------------
 swh/vault/tests/test_init.py | 55 ++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 122 insertions(+), 53 deletions(-)
 create mode 100644 swh/vault/tests/test_init.py
Changes applied before test
commit efd5eb4dbdb3b451997141b661cb9ae53b8c3c34
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

commit 4f1b89d01a441e1048c5a276773b37e3f7d2e276
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 15:50:06 2020 +0200

    vault.config: Adapt scheduler configuration structure

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/22/ for more details.

Harbormaster completed remote builds in B16406: Diff 15177.Oct 16 2020, 7:45 PM
ardumont edited the test plan for this revision. (Show Details)Oct 16 2020, 7:57 PM
ardumont updated this revision to Diff 15193.Oct 19 2020, 12:10 PM
ardumont edited the test plan for this revision. (Show Details)

Rebase

swh-public-ci added a comment.Oct 19 2020, 12:12 PM

Build is green

Patch application report for D4294 (id=15193)

Rebasing onto b5cecff6df...

Current branch diff-target is up to date.
Changes applied before test
commit 8e4026a5e8c9d43832cd3b038b9175f3f4914407
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 19:34:02 2020 +0200

    swh.vault: Unify get_vault factory function with other factories
    
    Related to T1410

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/24/ for more details.

Harbormaster completed remote builds in B16429: Diff 15193.Oct 19 2020, 12:12 PM
ardumont added inline comments.Oct 19 2020, 12:25 PM
swh/vault/api/server.py
229

D4295 for coverage.

vlorentz accepted this revision.Oct 19 2020, 12:41 PM
This revision is now accepted and ready to land.Oct 19 2020, 12:41 PM
Closed by commit rDVAU8e4026a5e8c9: swh.vault: Unify get_vault factory function with other factories (authored by ardumont). · Explain WhyOct 19 2020, 1:58 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDVAU8e4026a5e8c9: swh.vault: Unify get_vault factory function with other factories.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
swh/
vault/
53 lines100%
Loading...
api/
2 lines51%
Loading...
13 lines84%
Loading...
tests/
46 lines82%
Loading...
55 lines100%
Loading...

Diff 15193

View Options

requirements-test.txt

Loading...
View Options

swh/vault/__init__.py

Loading...
View Options

swh/vault/api/server.py

Loading...
View Options

swh/vault/backend.py

Loading...
View Options

swh/vault/tests/conftest.py

Loading...
View Options

swh/vault/tests/test_init.py

Loading...
About · Developer information · Legal