Differential D4287

Drop mock_get_scheduler which creates indirection for no good reason
ClosedPublic
Actions

Authored by ardumont on Oct 16 2020, 2:35 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLS30ad6200a2bf: Drop mock_get_scheduler which creates indirection for no good reason

Summary

This is no longer useful, as removing it and tests are still ok.

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 16385
Build 25236: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25235: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 16 2020, 2:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 2:35 PM

Build is green

Patch application report for D4287 (id=15157)

Rebasing onto 2ff92ef406...

Current branch diff-target is up to date.

Changes applied before test

commit 30ad6200a2bfaed4fd472c5343411703259baf82
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 14:30:54 2020 +0200

    Drop mock_get_scheduler which creates indirection for no good reason
    
    This is no longer useful, as removing it and tests are still ok.

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/55/ for more details.

Harbormaster completed remote builds in B16385: Diff 15157.Oct 16 2020, 2:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 19 2020, 9:44 AM

Closed by commit rDLS30ad6200a2bf: Drop mock_get_scheduler which creates indirection for no good reason (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS30ad6200a2bf: Drop mock_get_scheduler which creates indirection for no good reason.