Differential D4279

storage.api.server: Add types to module and refactor tests
ClosedPublic
Actions

Authored by ardumont on Oct 16 2020, 10:15 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDCIDX934592a141bc: storage.api.server: Add types to module and refactor tests

Summary

Refactor the tests to simplify the reading (use pytest.raises' match behavior)
Add types on impacted functions so the coverage shows as well

Not really for review. Preparatory work to fix configuration discrepancy which
is the source of the docker-dev error.

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16361
Build 25195: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 25194: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 16 2020, 10:15 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 16 2020, 10:15 AM

Build is green

Patch application report for D4279 (id=15134)

Rebasing onto 07c96743d7...

Current branch diff-target is up to date.

Changes applied before test

commit 934592a141bca2d494b9b02df5a802e4fc5bdc4e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 16 10:15:26 2020 +0200

    storage.api.server: Add types to module and refactor tests

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B16361: Diff 15134.Oct 16 2020, 10:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 16 2020, 10:18 AM

Closed by commit rDCIDX934592a141bc: storage.api.server: Add types to module and refactor tests (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX934592a141bc: storage.api.server: Add types to module and refactor tests.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

indexer/

storage/

api/

server.py

25 lines

79%

tests/

storage/

test_server.py

32 lines

100%

Diff 15134

View Options

swh/indexer/storage/api/server.py