Page MenuHomeSoftware Heritage

test_deposit: Clarify unexpected output in case of assertion failures
ClosedPublic

Authored by ardumont on Oct 15 2020, 2:50 PM.

Details

Summary

This helps when debugging when something failed unexpectedly.

Depends on D4269

Test Plan

tox

Diff Detail

Repository
rDICP Icinga plugins
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 15 2020, 2:50 PM

Build is green

Patch application report for D4270 (id=15099)

Could not rebase; Attempt merge onto 6f9b0d99ee...

Updating 6f9b0d9..5d43396
Fast-forward
 swh/icinga_plugins/tests/test_deposit.py | 159 +++++++++++++++++++------------
 1 file changed, 99 insertions(+), 60 deletions(-)
Changes applied before test
commit 5d43396856cf15f7989d5ce4e2ea8d289e9c05aa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 14:50:52 2020 +0200

    test_deposit: Clarify unexpected output in case of assertion failures

commit 2c326c4a0a8b2f77bc7f73332301f8352b81b2c9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 14:44:42 2020 +0200

    test_deposit: Introduce status_template helper function
    
    To ease incoming scenario updates (notably the deposit update metadata).

commit be18e1f9dd4ac7220d573443492d66a57b4981b9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 14:42:18 2020 +0200

    test_deposit: Use f-string instead of concatenate strings

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/13/ for more details.

vlorentz accepted this revision.Oct 15 2020, 4:32 PM
This revision is now accepted and ready to land.Oct 15 2020, 4:32 PM