Differential D4268

test_deposit: Use f-string instead of concatenate strings
ClosedPublic
Actions

Authored by ardumont on Oct 15 2020, 2:42 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDICPbe18e1f9dd4a: test_deposit: Use f-string instead of concatenate strings

Summary

This is simpler to read

Test Plan

tox

Diff Detail

Repository

rDICP Icinga plugins

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 15 2020, 2:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 15 2020, 2:42 PM

Build is green

Patch application report for D4268 (id=15097)

Rebasing onto 6f9b0d99ee...

Current branch diff-target is up to date.

Changes applied before test

commit be18e1f9dd4ac7220d573443492d66a57b4981b9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 15 14:42:18 2020 +0200

    test_deposit: Use f-string instead of concatenate strings

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/11/ for more details.

Harbormaster completed remote builds in B16323: Diff 15097.Oct 15 2020, 2:43 PM

ardumont added a child revision: D4269: test_deposit: Introduce status_template helper function.Oct 15 2020, 2:44 PM

ardumont mentioned this in D4252: Add deposit metadata update step in deposit icinga check.Oct 15 2020, 2:55 PM

vlorentz accepted this revision.Oct 15 2020, 4:31 PM

This revision is now accepted and ready to land.Oct 15 2020, 4:31 PM

Closed by commit rDICPbe18e1f9dd4a: test_deposit: Use f-string instead of concatenate strings (authored by ardumont). · Explain WhyOct 15 2020, 4:47 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDICPbe18e1f9dd4a: test_deposit: Use f-string instead of concatenate strings.

Revision Contents
Changeset List

Path

Size

swh/

icinga_plugins/

tests/

test_deposit.py

48 lines

Diff 15112

View Options

swh/icinga_plugins/tests/test_deposit.py

test_deposit: Use f-string instead of concatenate stringsClosedPublicActions