Page MenuHomeSoftware Heritage

Swap branches in the deletion flowchart
ClosedPublic

Authored by vlorentz on Tue, Oct 13, 5:29 PM.

Details

Summary

So the positive branch is first, and the negative is in the else.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Oct 13, 5:29 PM

Build is green

Patch application report for D4250 (id=15012)

Could not rebase; Attempt merge onto a8e6b830bb...

Updating a8e6b830..7df3c16e
Fast-forward
 docs/images/.gitignore               |  1 +
 docs/images/Makefile                 | 10 ++++
 docs/images/deposit-create-chart.uml | 26 +++++++++++
 docs/images/deposit-delete-chart.uml | 38 ++++++++++++++++
 docs/images/deposit-update-chart.uml | 37 +++++++++++++++
 docs/specs/blueprint.rst             | 88 +++++++++++++++++++++++++++++++-----
 6 files changed, 188 insertions(+), 12 deletions(-)
 create mode 100644 docs/images/.gitignore
 create mode 100644 docs/images/Makefile
 create mode 100644 docs/images/deposit-create-chart.uml
 create mode 100644 docs/images/deposit-delete-chart.uml
 create mode 100644 docs/images/deposit-update-chart.uml
Changes applied before test
commit 7df3c16e158248fd31ceb3bbc60ae5df1ee5d21a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:29:38 2020 +0200

    Swap branches in the deletion flowchart
    
    So the positive branch is first, and the negative is in the else.

commit 5a40d27c7cf95dcab4ecd5b8ca862ae90d9635d8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:28:57 2020 +0200

    Fix mistakes in the deletion flowchart

commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/229/ for more details.

ardumont accepted this revision.Tue, Oct 13, 6:20 PM
ardumont added a subscriber: ardumont.

there now it's clearer (see D4349, when i asked to drop the added not in the else instruction)

This revision is now accepted and ready to land.Tue, Oct 13, 6:20 PM

Build is green

Patch application report for D4250 (id=15020)

Could not rebase; Attempt merge onto a8e6b830bb...

Updating a8e6b830..2f5300e6
Fast-forward
 docs/images/.gitignore               |  1 +
 docs/images/Makefile                 | 10 ++++
 docs/images/deposit-create-chart.uml | 26 +++++++++++
 docs/images/deposit-delete-chart.uml | 38 ++++++++++++++++
 docs/images/deposit-update-chart.uml | 37 +++++++++++++++
 docs/specs/blueprint.rst             | 88 +++++++++++++++++++++++++++++++-----
 6 files changed, 188 insertions(+), 12 deletions(-)
 create mode 100644 docs/images/.gitignore
 create mode 100644 docs/images/Makefile
 create mode 100644 docs/images/deposit-create-chart.uml
 create mode 100644 docs/images/deposit-delete-chart.uml
 create mode 100644 docs/images/deposit-update-chart.uml
Changes applied before test
commit 2f5300e60af59f2c8a8706277bafe0b681b6c281
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:29:38 2020 +0200

    Swap branches in the deletion flowchart
    
    So the positive branch is first, and the negative is in the else.

commit 9cf6792987285a4e49713f3602dad89e29e8d1dd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:28:57 2020 +0200

    Fix mistakes in the deletion flowchart

commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/232/ for more details.

This revision was automatically updated to reflect the committed changes.