Page MenuHomeSoftware Heritage

Rewrite blueprint flowcharts using Plantuml instead of .png files.
ClosedPublic

Authored by vlorentz on Oct 13 2020, 5:27 PM.

Details

Summary

There are a few mistakes, but they were already in the original files;
a future commit will fix them.

Related to T2618

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16238
Build 24981: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24980: arc lint + arc unit

Event Timeline

remove changes that weren't supposed to be in this diff

Build is green

Patch application report for D4248 (id=15009)

Rebasing onto a8e6b830bb...

Current branch diff-target is up to date.
Changes applied before test
commit 13c45d647ad66db5f83291737b936cd6c49ce780
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/226/ for more details.

Build is green

Patch application report for D4248 (id=15010)

Rebasing onto a8e6b830bb...

Current branch diff-target is up to date.
Changes applied before test
commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/227/ for more details.

ardumont added inline comments.
docs/images/deposit-create-chart.uml
26

ok

docs/images/deposit-update-chart.uml
30

deposited instead of ready
And then the check can do its job and trigger the checks.
if checks ok -> verified (and now it's ready for injection).
else checks ko -> rejected.

[1] https://forge.softwareheritage.org/source/swh-deposit/browse/master/docs/images/status.png

docs/specs/blueprint.rst
55

Thanks a lot for this.

I see things can be improved again but that's not really the subject of the
diff (subject is technical rewrite ;). In the mean time, let's land it.

I can take care of the adaptations when this lands. (if you want).

Cheers,

This revision is now accepted and ready to land.Oct 14 2020, 9:35 AM
docs/images/deposit-update-chart.uml
30
docs/specs/blueprint.rst
55

D4260 and in the end i renamed all status names.