Rewrite blueprint flowcharts using Plantuml instead of .png files.
ClosedPublic
Actions

Authored by vlorentz on Oct 13 2020, 5:27 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2618: Re-draw the flowcharts in swh-deposit documentation using plantuml

Commits

rDDEP5622c4d80cb0: Rewrite blueprint flowcharts using Plantuml instead of .png files.

Summary

There are a few mistakes, but they were already in the original files;
a future commit will fix them.

deposit-create-chart.svg9 KBDownload

deposit-update-chart.svg13 KBDownload

deposit-delete-chart.svg14 KBDownload

Related to T2618

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16238
Build 24981: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24980: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 13 2020, 5:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 13 2020, 5:27 PM

remove changes that weren't supposed to be in this diff

Build is green

Patch application report for D4248 (id=15009)

Rebasing onto a8e6b830bb...

Current branch diff-target is up to date.

Changes applied before test

commit 13c45d647ad66db5f83291737b936cd6c49ce780
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/226/ for more details.

Harbormaster completed remote builds in B16237: Diff 15009.Oct 13 2020, 5:30 PM

vlorentz edited the summary of this revision. (Show Details)Oct 13 2020, 5:31 PM

Build is green

Patch application report for D4248 (id=15010)

Rebasing onto a8e6b830bb...

Current branch diff-target is up to date.

Changes applied before test

commit 5622c4d80cb08b27c0c1f7a32cb69dce156a6d4e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 13 17:25:26 2020 +0200

    Rewrite blueprint flowcharts using Plantuml instead of .png files.
    
    There are a few mistakes, but they were already in the original files;
    a future commit will fix them.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/227/ for more details.

Harbormaster completed remote builds in B16238: Diff 15010.Oct 13 2020, 5:32 PM

ardumont added a subscriber: ardumont.Oct 13 2020, 5:51 PM

ardumont added inline comments.

docs/images/deposit-create-chart.uml
26	ok
docs/images/deposit-update-chart.uml
30	`deposited` instead of `ready` And then the check can do its job and trigger the checks. if checks ok -> verified (and now it's ready for injection). else checks ko -> rejected. [1] https://forge.softwareheritage.org/source/swh-deposit/browse/master/docs/images/status.png
docs/specs/blueprint.rst
55	verified. we are missing the deposited status... [1] [1] https://forge.softwareheritage.org/source/swh-deposit/browse/master/docs/images/status.png