Page MenuHomeSoftware Heritage
Differential D4246

fuse: add support for release artifacts
ClosedPublic
Actions

Authored by haltode on Oct 13 2020, 3:19 PM.

Details

Reviewers
seirl
Group Reviewers
Reviewers
Maniphest Tasks
T2664: FUSE: add support for release objects
Commits
rDFUSE7d59abcc8d07: fuse: add support for release artifacts
Summary

Closes T2664.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Oct 13 2020, 3:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 13 2020, 3:19 PM
swh-public-ci added a comment.Oct 13 2020, 3:20 PM

Build is green

Patch application report for D4246 (id=15000)

Rebasing onto de84c9de3a...

Current branch diff-target is up to date.
Changes applied before test
commit cadcc60ce37b7fb0485e3ea2c61cc1a7f27e4ae8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/63/ for more details.

Harbormaster completed remote builds in B16225: Diff 15000.Oct 13 2020, 3:20 PM
haltode added a comment.Oct 13 2020, 3:22 PM

TODO: test releases with other target's types

seirl requested changes to this revision.Oct 13 2020, 3:31 PM
seirl added a subscriber: seirl.
seirl added inline comments.
swh/fuse/fs/artifact.py
192

This function name is confusing. Maybe find_transitive_directory or find_root_directory? Otherwise it really looks like you're searching for the target node.

swh/fuse/tests/data/gen-api-data.py
87

Don't you want recursive=recursive here instead?

This revision now requires changes to proceed.Oct 13 2020, 3:31 PM
haltode updated this revision to Diff 15004.Oct 13 2020, 4:27 PM
haltode marked 2 inline comments as done.

Rename get_target_directory to find_root_directory.

swh/fuse/tests/data/gen-api-data.py
87

If we hit this line then recursive is necessarly True (because of the if), so I wanted to be more explicit in the function call (this function recursive behavior is very likely to be changed anyway once T2700 is fixed).

swh-public-ci added a comment.Oct 13 2020, 4:29 PM

Build is green

Patch application report for D4246 (id=15004)

Rebasing onto 2312f6e9c7...

First, rewinding head to replay your work on top of it...
Applying: fuse: add support for release artifacts
Changes applied before test
commit 7e7eaca5860b3df57625c790def843ac1e610d2f
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/64/ for more details.

Harbormaster completed remote builds in B16233: Diff 15004.Oct 13 2020, 4:29 PM
seirl accepted this revision.Oct 13 2020, 4:34 PM
This revision is now accepted and ready to land.Oct 13 2020, 4:34 PM
haltode updated this revision to Diff 15006.Oct 13 2020, 4:46 PM

Rebasing on master.

swh-public-ci added a comment.Oct 13 2020, 4:48 PM

Build is green

Patch application report for D4246 (id=15006)

Rebasing onto 2312f6e9c7...

Current branch diff-target is up to date.
Changes applied before test
commit a01f8973235ade35b0f26ae91815858958d3eb85
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/65/ for more details.

Harbormaster completed remote builds in B16234: Diff 15006.Oct 13 2020, 4:48 PM
haltode updated this revision to Diff 15007.Oct 13 2020, 5:15 PM

Add unit tests for releases with cnt/dir targets

swh-public-ci added a comment.Oct 13 2020, 5:16 PM

Build is green

Patch application report for D4246 (id=15007)

Rebasing onto 2312f6e9c7...

Current branch diff-target is up to date.
Changes applied before test
commit 7d59abcc8d070e33b83bf70a3e85c9dc0022a29d
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/66/ for more details.

Harbormaster completed remote builds in B16235: Diff 15007.Oct 13 2020, 5:16 PM
Closed by commit rDFUSE7d59abcc8d07: fuse: add support for release artifacts (authored by haltode). · Explain WhyOct 13 2020, 5:19 PM
This revision was automatically updated to reflect the committed changes.
haltode added a commit: rDFUSE7d59abcc8d07: fuse: add support for release artifacts.

Revision Contents
Changeset List

PathSize
swh/
fuse/
fs/
78 lines
tests/
15 lines
data/
130 lines
18 lines
55 lines
7 lines
46 lines
7 lines

Diff 15008

View Options

swh/fuse/fs/artifact.py

Loading...
View Options

swh/fuse/tests/common.py

Loading...
View Options

swh/fuse/tests/data/api_data.py

Loading...
View Options

swh/fuse/tests/data/config.py

Loading...
View Options

swh/fuse/tests/data/gen-api-data.py

Loading...
View Options

swh/fuse/tests/test_directory.py

Loading...
View Options

swh/fuse/tests/test_release.py

Loading...
View Options

swh/fuse/tests/test_revision.py

Loading...
About · Developer information · Legal