Page MenuHomeSoftware Heritage

fuse: add support for release artifacts
ClosedPublic

Authored by haltode on Tue, Oct 13, 3:19 PM.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Tue, Oct 13, 3:19 PM

Build is green

Patch application report for D4246 (id=15000)

Rebasing onto de84c9de3a...

Current branch diff-target is up to date.
Changes applied before test
commit cadcc60ce37b7fb0485e3ea2c61cc1a7f27e4ae8
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/63/ for more details.

TODO: test releases with other target's types

seirl requested changes to this revision.Tue, Oct 13, 3:31 PM
seirl added a subscriber: seirl.
seirl added inline comments.
swh/fuse/fs/artifact.py
193

This function name is confusing. Maybe find_transitive_directory or find_root_directory? Otherwise it really looks like you're searching for the target node.

swh/fuse/tests/data/gen-api-data.py
88

Don't you want recursive=recursive here instead?

This revision now requires changes to proceed.Tue, Oct 13, 3:31 PM
haltode updated this revision to Diff 15004.Tue, Oct 13, 4:27 PM
haltode marked 2 inline comments as done.

Rename get_target_directory to find_root_directory.

swh/fuse/tests/data/gen-api-data.py
88

If we hit this line then recursive is necessarly True (because of the if), so I wanted to be more explicit in the function call (this function recursive behavior is very likely to be changed anyway once T2700 is fixed).

Build is green

Patch application report for D4246 (id=15004)

Rebasing onto 2312f6e9c7...

First, rewinding head to replay your work on top of it...
Applying: fuse: add support for release artifacts
Changes applied before test
commit 7e7eaca5860b3df57625c790def843ac1e610d2f
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/64/ for more details.

seirl accepted this revision.Tue, Oct 13, 4:34 PM
This revision is now accepted and ready to land.Tue, Oct 13, 4:34 PM
haltode updated this revision to Diff 15006.Tue, Oct 13, 4:46 PM

Rebasing on master.

Build is green

Patch application report for D4246 (id=15006)

Rebasing onto 2312f6e9c7...

Current branch diff-target is up to date.
Changes applied before test
commit a01f8973235ade35b0f26ae91815858958d3eb85
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/65/ for more details.

haltode updated this revision to Diff 15007.Tue, Oct 13, 5:15 PM

Add unit tests for releases with cnt/dir targets

Build is green

Patch application report for D4246 (id=15007)

Rebasing onto 2312f6e9c7...

Current branch diff-target is up to date.
Changes applied before test
commit 7d59abcc8d070e33b83bf70a3e85c9dc0022a29d
Author: Thibault Allançon <haltode@gmail.com>
Date:   Tue Oct 13 13:51:56 2020 +0200

    fuse: add support for release artifacts
    
    Closes T2664.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/66/ for more details.

This revision was automatically updated to reflect the committed changes.