Page MenuHomeSoftware Heritage

Vagrantfile: Migrate vms to use libvirt
ClosedPublic

Authored by ardumont on Mon, Oct 12, 5:42 PM.

Details

Summary

This also drops the qemutest vm as it became redundant with the test one.

Test Plan

vagrant up <some-vm> of your choosing.

Diff Detail

Repository
rSENV Puppet Environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mon, Oct 12, 5:42 PM
ardumont added inline comments.Mon, Oct 12, 5:45 PM
Vagrantfile
33

wondering whether we want that check on /tmp/puppet as well (mentioning if missing that we need to run /bin/prepare-vagrant.sh or some such).

105

dude, 4096!

ardumont updated this revision to Diff 14963.Mon, Oct 12, 5:51 PM

Update prod-worker01's memory setting

vsellier accepted this revision as: vsellier.Mon, Oct 12, 6:03 PM
vsellier added a subscriber: vsellier.

LGTM (not tested)

For the test of the /tmp/puppet existence, it could be great but the message is quite explicit when the directory does not exists :

vm:
* The host path of the shared folder is missing: /tmp/puppet/

I'm not sure if it's worth it to invest a lot of time on this.

This revision is now accepted and ready to land.Mon, Oct 12, 6:03 PM

LGTM (not tested)

For the test of the /tmp/puppet existence, it could be great but the message is quite explicit when the directory does not exists :

vm:
* The host path of the shared folder is missing: /tmp/puppet/

I'm not sure if it's worth it to invest a lot of time on this.

yes, agreed ;)

yes, agreed ;)

although, now i'm thinking if someone did not read the documentation (that can always happen), they don't know what the next step is and a nudge in the right direction could help...
Be that, "please the readme" (with an internal link) to the paragraph mentioning the scripts for either the scripts prepare-vagrant-conf or watch-vagrant-conf or directly mentioning those?

just thinking out loud here ;)

This revision was automatically updated to reflect the committed changes.