Page MenuHomeSoftware Heritage

common/archive: Fix empty content handling in lookup_content_raw
ClosedPublic

Authored by anlambert on Mon, Oct 12, 4:33 PM.

Details

Summary

The bytes of the empty content are currently reported as missing in the archive
due to an invalid test in swh.common.archive.lookup_content_raw.

See https://archive.softwareheritage.org/api/1/content/sha1_git:e69de29bb2d1d6434b8b29ae775ad8c2e48c5391/raw/

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Mon, Oct 12, 4:33 PM

Build is green

Patch application report for D4237 (id=14954)

Rebasing onto 0e98684bdb...

Current branch diff-target is up to date.
Changes applied before test
commit 5408eabc2c44b5e581d537be9516a46d1bc71687
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Oct 12 16:23:22 2020 +0200

    common/archive: Fix empty content handling in lookup_content_raw

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/409/ for more details.

ardumont accepted this revision.Mon, Oct 12, 5:06 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/web/tests/common/test_archive.py
633

f-string?

This revision is now accepted and ready to land.Mon, Oct 12, 5:06 PM
anlambert updated this revision to Diff 14958.Mon, Oct 12, 5:26 PM

Use f-string

Build is green

Patch application report for D4237 (id=14958)

Rebasing onto 0e98684bdb...

Current branch diff-target is up to date.
Changes applied before test
commit eb077d9cb6c4615bf8550ac84a747dd3565acd76
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Oct 12 16:23:22 2020 +0200

    common/archive: Fix empty content handling in lookup_content_raw

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/410/ for more details.