First, rewinding head to replay your work on top of it...
Applying: Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of silencing them.

Changes applied before test

commit 651ba6c1536af3418bcc0127388474830378e153
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 6 12:31:10 2020 +0200

    Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of silencing them.
    
    Since eed3531328681397f07aa67715bbe59def7f4d98, the 'finally' clause silenced re-raised
    exception because it contains a 'return' statement.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/61/ for more details.

Harbormaster completed remote builds in B15920: Diff 14640.Oct 6 2020, 12:33 PM

ardumont accepted this revision.Oct 6 2020, 12:35 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/tests/test_indexer.py
37	I don't even recall we had a `self.catch_exceptions`...

This revision is now accepted and ready to land.Oct 6 2020, 12:35 PM

vlorentz added inline comments.Oct 6 2020, 12:37 PM

swh/indexer/tests/test_indexer.py
37	So tests raises a nice error instead of silently passing and then crashing later when they check the content of the storage.. I just got bitten by this while refactoring the storage.

rebase

This revision was landed with ongoing or failed builds.Oct 6 2020, 12:37 PM

Closed by commit rDCIDX3ac0c155dad5: Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of… (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX3ac0c155dad5: Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of….

Build is green

Patch application report for D4151 (id=14641)

Rebasing onto 1eb521c98c...

Current branch diff-target is up to date.

Changes applied before test

commit 3ac0c155dad552fdd921561974d52164dcfc8820
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Oct 6 12:31:10 2020 +0200

    Make BaseIndexer.catch_exception=False actually re-raise exceptions instead of silencing them.
    
    Since eed3531328681397f07aa67715bbe59def7f4d98, the 'finally' clause silenced re-raised
    exception because it contains a 'return' statement.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/62/ for more details.

Harbormaster completed remote builds in B15921: Diff 14641.Oct 6 2020, 12:39 PM