Differential D4135

test_cookers: Turn git_loader into a pytest fixture
ClosedPublic
Actions

Authored by anlambert on Oct 2 2020, 8:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDVAUa8fa57718b69: test_cookers: Turn git_loader into a pytest fixture

Summary

It enables to remove some code duplication related to git loader creation
when executing tests.

Diff Detail

Repository

rDVAU Software Heritage Vault

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15861
Build 24411: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24410: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 2 2020, 8:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 2 2020, 8:56 PM

anlambert mentioned this in D4134: tests: Fix loader git instantiation.Oct 2 2020, 8:57 PM

Build is green

Patch application report for D4135 (id=14580)

Rebasing onto 7af35ae919...

Current branch diff-target is up to date.

Changes applied before test

commit a8fa57718b694d8c50e166910a5ed9549fc5a246
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 2 20:52:26 2020 +0200

    test_cookers: Turn git_loader into a pytest fixture
    
    It enables to remove some code duplication related to git loader creation
    when executing tests.

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/19/ for more details.

Harbormaster completed remote builds in B15861: Diff 14580.Oct 2 2020, 8:58 PM

ardumont accepted this revision.Oct 3 2020, 6:15 PM

This revision is now accepted and ready to land.Oct 3 2020, 6:15 PM

Closed by commit rDVAUa8fa57718b69: test_cookers: Turn git_loader into a pytest fixture (authored by anlambert). · Explain WhyOct 5 2020, 11:40 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDVAUa8fa57718b69: test_cookers: Turn git_loader into a pytest fixture.