Page MenuHomeSoftware Heritage

browse: Do not lookup license info for a content as it is not used
ClosedPublic

Authored by anlambert on Oct 2 2020, 2:31 PM.

Details

Summary

The license information for a content is not displayed in the Web UI so
let's save a lookup to the indexer database when browsing the archive.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15819
Build 24351: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 24350: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Oct 2 2020, 2:33 PM

Build has FAILED

Patch application report for D4129 (id=14557)

Rebasing onto 502ca47e59...

Current branch diff-target is up to date.
Changes applied before test
commit 8d72a8ca589a66b04383a832cd12ce9c7855bdcb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 2 14:29:43 2020 +0200

    browse: Do not lookup license info for a content as it is not used

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/398/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/398/console

Build has FAILED

Patch application report for D4129 (id=14557)

Rebasing onto 502ca47e59...

Current branch diff-target is up to date.
Changes applied before test
commit 8d72a8ca589a66b04383a832cd12ce9c7855bdcb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 2 14:29:43 2020 +0200

    browse: Do not lookup license info for a content as it is not used

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/398/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/398/console

Looks like configuration refactoring impacts swh-web.

Build is green

Patch application report for D4129 (id=14557)

Rebasing onto 502ca47e59...

Current branch diff-target is up to date.
Changes applied before test
commit 8d72a8ca589a66b04383a832cd12ce9c7855bdcb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Oct 2 14:29:43 2020 +0200

    browse: Do not lookup license info for a content as it is not used

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/399/ for more details.