git.loader: Migrate away from SWHConfig mixin
ClosedPublic
Actions

Authored by ardumont on Oct 2 2020, 10:42 AM.

Details

Reviewers

tenma
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1410: Kill implicit configuration: new configuration scheme
T1532: Cleanup deprecated configuration code in swh modules

Commits

rDLDGca7556c35604: git.loader: Migrate away from SWHConfig mixin

Summary

Related to T1532 T1410 D3965

Test Plan

tox

and docker:

time doco exec swh-loader swh loader run git https://github.com/huge-success/sanic.git
INFO:swh.loader.git.BulkLoader:Load origin 'https://github.com/huge-success/sanic.git' with type 'git'
Enumerating objects: 143, done.
Counting objects: 100% (143/143), done.
Compressing objects: 100% (102/102), done.
Total 15402 (delta 78), reused 77 (delta 40), pack-reused 15259
INFO:swh.loader.git.BulkLoader:Listed 1072 refs for repo https://github.com/huge-success/sanic.git
{'status': 'eventful'}
docker-compose exec swh-loader swh loader run git   0.49s user 0.39s system 1% cpu 48.581 total

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15795
Build 24314: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24313: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 2 2020, 10:42 AM

ardumont mentioned this in D4124: core.loader: Migrate away from SWHConfig mixin.Oct 2 2020, 10:43 AM

Build is green

Patch application report for D4128 (id=14533)

Rebasing onto cc342acede...

Current branch diff-target is up to date.

Changes applied before test

commit 47310ff9d279ccb732610de4d77f5bb4198d5ffe
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:41:04 2020 +0200

    git.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B15795: Diff 14533.Oct 2 2020, 10:44 AM

Drop unused config parameter passed to contructor

Build is green

Patch application report for D4128 (id=14534)

Rebasing onto cc342acede...

Current branch diff-target is up to date.

Changes applied before test

commit ca7556c35604934a235a2d60b582ad3d4c64426b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:41:04 2020 +0200

    git.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/61/ for more details.

Harbormaster completed remote builds in B15796: Diff 14534.Oct 2 2020, 10:47 AM

ardumont mentioned this in D3965: config: Deprecate SWHConfig in favor of load_from_envvar function.Oct 2 2020, 10:53 AM

vlorentz accepted this revision.Oct 2 2020, 11:16 AM

This revision is now accepted and ready to land.Oct 2 2020, 11:16 AM

Build is green

Patch application report for D4128 (id=14534)

Rebasing onto cc342acede...

Current branch diff-target is up to date.

Changes applied before test

commit ca7556c35604934a235a2d60b582ad3d4c64426b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:41:04 2020 +0200

    git.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/62/ for more details.

Build is green

Patch application report for D4128 (id=14534)

Rebasing onto cc342acede...

Current branch diff-target is up to date.

Changes applied before test

commit ca7556c35604934a235a2d60b582ad3d4c64426b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:41:04 2020 +0200

    git.loader: Migrate away from SWHConfig mixin
    
    Related to T1532 T1410 D3965

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/63/ for more details.

ardumont edited the test plan for this revision. (Show Details)Oct 2 2020, 2:10 PM

Closed by commit rDLDGca7556c35604: git.loader: Migrate away from SWHConfig mixin (authored by ardumont). · Explain WhyOct 2 2020, 2:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDGca7556c35604: git.loader: Migrate away from SWHConfig mixin.

ardumont mentioned this in T1532: Cleanup deprecated configuration code in swh modules.Oct 5 2020, 12:59 PM