svn.loader: Migrate away from SWHConfig mixin
ClosedPublic
Actions

Authored by ardumont on Oct 2 2020, 10:24 AM.

Details

Reviewers

tenma
vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T1410: Kill implicit configuration: new configuration scheme
T1532: Cleanup deprecated configuration code in swh modules

Commits

rDLDSVN87d4a7e22f63: svn.loader: Migrate away from SWHConfig mixin

Summary

Related to T1532
Related to T1410
Related to D3965

Test Plan

tox

and

docker run (with docker-compose.override.yml):

time doco exec swh-loader swh loader run svn svn://scm.gforge.inria.fr/svnroot/fdf/
INFO:swh.loader.svn.SvnLoader:Load origin 'svn://scm.gforge.inria.fr/svnroot/fdf/' with type 'svn'
INFO:swh.loader.svn.SvnLoader:Processing revisions [1-922] for {'swh-origin': 'svn://scm.gforge.inria.fr/svnroot/fdf/', 'remote_url': 'svn://scm.gforge.inria.fr/svnroot/fdf', 'local_url': b'/tmp/swh.loader.svn.gytutrft-204/fdf', 'uuid': b'0491c1f1-070f-0410-b5d3-808586ddf757'}
{'status': 'eventful'}
docker-compose exec swh-loader swh loader run svn   0.58s user 0.48s system 0% cpu 4:29.62 total

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 2 2020, 10:24 AM

ardumont added inline comments.Oct 2 2020, 10:24 AM

swh/loader/svn/tests/conftest.py
36	Those are defaults from the core loader, so to actually demonstrate it works, i've removed them...

Build is green

Patch application report for D4126 (id=14530)

Rebasing onto 47b03e1959...

Current branch diff-target is up to date.

Changes applied before test

commit 5110b149ed8cfb22c785dced39bd54935573ba9e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:24:31 2020 +0200

    svn.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/96/ for more details.

Harbormaster completed remote builds in B15792: Diff 14530.Oct 2 2020, 10:25 AM

ardumont mentioned this in D4124: core.loader: Migrate away from SWHConfig mixin.Oct 2 2020, 10:43 AM

ardumont mentioned this in D3965: config: Deprecate SWHConfig in favor of load_from_envvar function.Oct 2 2020, 10:53 AM

vlorentz added a subscriber: vlorentz.Oct 2 2020, 11:15 AM

vlorentz added inline comments.

swh/loader/svn/loader.py
50	a part of the sentence is missing.

ardumont added inline comments.Oct 2 2020, 11:31 AM

swh/loader/svn/loader.py
50	thanks, we'll probably need to rename this variable... It's used not for logging in the end but to prevent a clean up of the disk at the end of the svn loading. So a manual debug on disk can occur... It's poorly named i think.

Fix docstring sentence

Build is green

Patch application report for D4126 (id=14546)

Rebasing onto 47b03e1959...

Current branch diff-target is up to date.

Changes applied before test

commit 87d4a7e22f632c181036455a67bdaf7646779557
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:24:31 2020 +0200

    svn.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/97/ for more details.

Harbormaster completed remote builds in B15808: Diff 14546.Oct 2 2020, 11:33 AM

Build is green

Patch application report for D4126 (id=14546)

Rebasing onto 47b03e1959...

Current branch diff-target is up to date.

Changes applied before test

commit 87d4a7e22f632c181036455a67bdaf7646779557
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:24:31 2020 +0200

    svn.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/98/ for more details.

vlorentz accepted this revision.Oct 2 2020, 12:36 PM

This revision is now accepted and ready to land.Oct 2 2020, 12:36 PM

Build is green

Patch application report for D4126 (id=14546)

Rebasing onto 47b03e1959...

Current branch diff-target is up to date.

Changes applied before test

commit 87d4a7e22f632c181036455a67bdaf7646779557
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 2 10:24:31 2020 +0200

    svn.loader: Migrate away from SWHConfig mixin
    
    Related to T1532
    Related to T1410
    Related to D3965

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/99/ for more details.

ardumont edited the test plan for this revision. (Show Details)Oct 2 2020, 2:10 PM

Closed by commit rDLDSVN87d4a7e22f63: svn.loader: Migrate away from SWHConfig mixin (authored by ardumont). · Explain WhyOct 2 2020, 2:15 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDSVN87d4a7e22f63: svn.loader: Migrate away from SWHConfig mixin.

ardumont mentioned this in T1532: Cleanup deprecated configuration code in swh modules.Oct 5 2020, 12:59 PM