Page MenuHomeSoftware Heritage
Differential D4107

vagrant: Install the virtualbox guest additions directly during the image creation
ClosedPublic
Actions

Authored by vsellier on Oct 1 2020, 10:15 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rSENV00a5f064fb73: vagrant: Install the virtualbox guest additions directly during the image…

Diff Detail

Repository
rSENV Puppet Environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15746
Build 24239: arc lint + arc unit

Event Timeline

vsellier created this revision.Oct 1 2020, 10:15 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 1 2020, 10:15 AM
Harbormaster completed remote builds in B15744: Diff 14467.Oct 1 2020, 10:15 AM
ardumont requested changes to this revision.Oct 1 2020, 10:22 AM
ardumont added a subscriber: ardumont.

careful a hardcoded netbox environment inserted itself inside

otherwise looks good to me.

requested change for the sake of my remark.

Vagrantfile
115

i gather this needs to be reverted ;)

This revision now requires changes to proceed.Oct 1 2020, 10:22 AM
vsellier updated this revision to Diff 14469.Oct 1 2020, 11:24 AM

Revert the netbox typo

Harbormaster completed remote builds in B15746: Diff 14469.Oct 1 2020, 11:24 AM
ardumont accepted this revision.Oct 1 2020, 11:25 AM
This revision is now accepted and ready to land.Oct 1 2020, 11:25 AM
vsellier marked an inline comment as done.Oct 1 2020, 11:25 AM
vsellier added inline comments.
Vagrantfile
115

as always good catch ;). It's reverted

Closed by commit rSENV00a5f064fb73: vagrant: Install the virtualbox guest additions directly during the image… (authored by vsellier). · Explain WhyOct 1 2020, 11:26 AM
This revision was automatically updated to reflect the committed changes.
vsellier marked an inline comment as done.
vsellier added a commit: rSENV00a5f064fb73: vagrant: Install the virtualbox guest additions directly during the image….

Revision Contents
Changeset List

PathSize
3 lines
8 lines
packer/
8 lines
scripts/
26 lines
7 lines

Diff 14469

View Options

README.md

Loading...
View Options

Vagrantfile

Loading...
View Options

packer/debian_buster.json

Loading...
View Options

packer/scripts/install-vbguest.sh

Loading...
View Options

packer/scripts/post-install.sh

Loading...
About · Developer information · Legal