Page MenuHomeSoftware Heritage

Fix metadata reading when a deposit is a multiple metadata requests instance
ClosedPublic

Authored by ardumont on Jul 24 2018, 12:25 PM.

Details

Summary

private/deposit_read: Use list comprehension to simplify reading
deposit.utils: Capture the wrong merge behavior in a test to fix
deposit.utils: Fix the potential metadata information loss

Close T1154

Test Plan

tests ok

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1365
Build 1709: arc lint + arc unit

Event Timeline

swh/deposit/tests/test_utils.py
62

no longer true ;)

Amended commit to remove a no longer true comment

  • deposit.utils: Fix the potential metadata information loss
This revision is now accepted and ready to land.Jul 24 2018, 2:04 PM

Add some edge cases in tests

  • deposit.utils: Fix the potential metadata information loss

https://forge.softwareheritage.org/P285 (for my local tests)

Yes, adapted and added some tests inspired from those.
Thanks.

This revision was automatically updated to reflect the committed changes.