Fix metadata reading when a deposit is a multiple metadata requests instance
ClosedPublic
Actions

Authored by ardumont on Jul 24 2018, 12:25 PM.

Details

Reviewers

Maniphest Tasks

T1154: Fix metadata reading when a deposit is a multiple metadata requests instance

Commits

rDDEPa70a2ad08bf5: deposit.utils: Capture the wrong merge behavior in a test to fix
rDDEP19ca52e605ab: deposit.utils: Fix the potential metadata information loss
rDDEP6fd67e8f6ff2: private/deposit_read: Use list comprehension to simplify reading

Summary

private/deposit_read: Use list comprehension to simplify reading
deposit.utils: Capture the wrong merge behavior in a test to fix
deposit.utils: Fix the potential metadata information loss

Close T1154

Test Plan

tests ok

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 24 2018, 12:25 PM

Harbormaster completed remote builds in B1365: Diff 1248.Jul 24 2018, 12:25 PM

ardumont added inline comments.Jul 24 2018, 1:32 PM

swh/deposit/tests/test_utils.py
62 ↗	(On Diff #1248)	no longer true ;)

Amended commit to remove a no longer true comment

deposit.utils: Fix the potential metadata information loss

Harbormaster completed remote builds in B1366: Diff 1249.Jul 24 2018, 1:33 PM

ardumont marked an inline comment as done.Jul 24 2018, 1:34 PM

moranegg accepted this revision.Jul 24 2018, 2:04 PM

This revision is now accepted and ready to land.Jul 24 2018, 2:04 PM

https://forge.softwareheritage.org/P285 (for my local tests)

Add some edge cases in tests

deposit.utils: Fix the potential metadata information loss

Harbormaster completed remote builds in B1367: Diff 1250.Jul 24 2018, 2:10 PM

https://forge.softwareheritage.org/P285 (for my local tests)

Yes, adapted and added some tests inspired from those.
Thanks.

Closed by commit rDDEP6fd67e8f6ff2: private/deposit_read: Use list comprehension to simplify reading (authored by ardumont). · Explain WhyJul 24 2018, 2:14 PM

This revision was automatically updated to reflect the committed changes.

anlambert mentioned this in D2407: Fix tests data initialization after git loader api changes.Dec 6 2019, 5:32 PM

Revision Contents
Changeset List

Path

Size

swh/

deposit/

api/

private/

deposit_read.py

18 lines

Diff 1251

View Options

swh/deposit/api/private/deposit_read.py

Fix metadata reading when a deposit is a multiple metadata requests instanceClosedPublicActions