Currently, only in partial status, but also in 'ready' state in the near future.
Details
Details
- Reviewers
moranegg - Group Reviewers
Reviewers - Commits
- rDDEPb820c61d67ae: blueprint: detail when deposit updates are allowed.
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15605 Build 24025: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 24024: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3999 (id=14091)
Rebasing onto 027169a72b...
Current branch diff-target is up to date.
Changes applied before test
commit 00f3ec00bcd0d1278c814a870324f6d2ced91a76
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 18 18:10:22 2020 +0200
blueprint: detail when deposit updates are allowed.
Currently, only in partial status, but also in 'ready' state in the near future.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/100/ for more details.
Comment Actions
just my 2c. do we want to allow deposit update in the ready state or do we want to be able to get back from ready to partial?
Comment Actions
@douardda I decided against going back to partial because it introduces a lot of complexity, and I can't see a use for it. partial is only useful to depositing stuff in multiple parts (several tarballs that get combined and metadata), but here there's only the metadata file.
I'll update the diff to make it clearer, though.
Comment Actions
- rename ready state to done to match the real implem
- explain partial deposits arenot allowed in updates.
Comment Actions
Build is green
Patch application report for D3999 (id=14099)
Rebasing onto 027169a72b...
Current branch diff-target is up to date.
Changes applied before test
commit 1a8f5088d2c506023e620c7d57c90db323b2a225
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 18 18:10:22 2020 +0200
blueprint: detail when deposit updates are allowed.
Currently, only in partial status, but also in 'ready' state in the near future.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/101/ for more details.
Comment Actions
Build is green
Patch application report for D3999 (id=14101)
Rebasing onto 027169a72b...
Current branch diff-target is up to date.
Changes applied before test
commit 92bd9260ec83240c4f933cc4db69bb528f12b8b5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 18 18:10:22 2020 +0200
blueprint: detail when deposit updates are allowed.
Currently, only in partial status, but also in 'ready' state in the near future.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/102/ for more details.
| docs/specs/blueprint.rst | ||
|---|---|---|
| 65 | are we? what is the use case for that? | |
| docs/specs/blueprint.rst | ||
|---|---|---|
| 65 | (for the record: I wrongfully wrote "deposited" instead of "done") | |
Comment Actions
Build is green
Patch application report for D3999 (id=14120)
Rebasing onto 027169a72b...
Current branch diff-target is up to date.
Changes applied before test
commit f8f28763a2c9edcf6703ca7a5f546c1c92b38db9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Sep 18 18:10:22 2020 +0200
blueprint: detail when deposit updates are allowed.
Currently, only in partial status, but also in 'ready' state in the near future.See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/103/ for more details.
Comment Actions
Build is green
Patch application report for D3999 (id=14307)
Rebasing onto b820c61d67...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-129-D3999.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/129/ for more details.