Page MenuHomeSoftware Heritage

blueprint: detail when deposit updates are allowed.
ClosedPublic

Authored by vlorentz on Sep 18 2020, 6:10 PM.

Details

Summary

Currently, only in partial status, but also in 'ready' state in the near future.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15358
Build 23654: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23653: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3999 (id=14091)

Rebasing onto 027169a72b...

Current branch diff-target is up to date.
Changes applied before test
commit 00f3ec00bcd0d1278c814a870324f6d2ced91a76
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 18 18:10:22 2020 +0200

    blueprint: detail when deposit updates are allowed.
    
    Currently, only in partial status, but also in 'ready' state in the near future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/100/ for more details.

just my 2c. do we want to allow deposit update in the ready state or do we want to be able to get back from ready to partial?

@douardda I decided against going back to partial because it introduces a lot of complexity, and I can't see a use for it. partial is only useful to depositing stuff in multiple parts (several tarballs that get combined and metadata), but here there's only the metadata file.

I'll update the diff to make it clearer, though.

Hmmm, but we may want to bring them back in deposited or verified state too...

  • rename ready state to done to match the real implem
  • explain partial deposits arenot allowed in updates.

Build is green

Patch application report for D3999 (id=14099)

Rebasing onto 027169a72b...

Current branch diff-target is up to date.
Changes applied before test
commit 1a8f5088d2c506023e620c7d57c90db323b2a225
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 18 18:10:22 2020 +0200

    blueprint: detail when deposit updates are allowed.
    
    Currently, only in partial status, but also in 'ready' state in the near future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/101/ for more details.

explicit that the state after a deposit update is 'deposited'.

Build is green

Patch application report for D3999 (id=14101)

Rebasing onto 027169a72b...

Current branch diff-target is up to date.
Changes applied before test
commit 92bd9260ec83240c4f933cc4db69bb528f12b8b5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 18 18:10:22 2020 +0200

    blueprint: detail when deposit updates are allowed.
    
    Currently, only in partial status, but also in 'ready' state in the near future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/102/ for more details.

moranegg added inline comments.
docs/specs/blueprint.rst
65

are we? what is the use case for that?

fix typo / wrong state name.

vlorentz added inline comments.
docs/specs/blueprint.rst
65

(for the record: I wrongfully wrote "deposited" instead of "done")

Build is green

Patch application report for D3999 (id=14120)

Rebasing onto 027169a72b...

Current branch diff-target is up to date.
Changes applied before test
commit f8f28763a2c9edcf6703ca7a5f546c1c92b38db9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 18 18:10:22 2020 +0200

    blueprint: detail when deposit updates are allowed.
    
    Currently, only in partial status, but also in 'ready' state in the near future.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/103/ for more details.

This revision is now accepted and ready to land.Sep 22 2020, 4:10 PM
This revision was landed with ongoing or failed builds.Sep 26 2020, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3999 (id=14307)

Rebasing onto b820c61d67...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-129-D3999.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/129/ for more details.