Page MenuHomeSoftware Heritage
Differential D3993

Small fix in the graph replayer to prevent a wrong warning
ClosedPublic
Actions

Authored by douardda on Sep 18 2020, 4:33 PM.

Details

Reviewers
anlambert
ardumont
Group Reviewers
Reviewers
Commits
rDSTO67ee86b8e03f: Warn about skipped_content sneaking the 'content' topics
rDSTO8de656451239: Small fix in the graph replayer to prevent a wrong warning
Summary

and warn about skipped_content sneaking the 'content' topics

Diff Detail

Event Timeline

douardda created this revision.Sep 18 2020, 4:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 18 2020, 4:33 PM
swh-public-ci added a comment.Sep 18 2020, 4:38 PM

Build is green

Patch application report for D3993 (id=14076)

Rebasing onto b0027abc34...

Current branch diff-target is up to date.
Changes applied before test
commit 533e9cb6d31df6948afc7272f6d25d3d548b809e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Sep 18 16:31:35 2020 +0200

    Warn about skipped_content sneaking the 'content' topics

commit 8de6564512398b86a406668beeac88737ffb8fa2
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Sep 18 16:30:37 2020 +0200

    Small fix in the graph replayer to prevent a wrong warning

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/951/ for more details.

Harbormaster completed remote builds in B15344: Diff 14076.Sep 18 2020, 4:38 PM
anlambert accepted this revision.Sep 18 2020, 4:48 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/storage/replay.py
120

s/any more/anymore/

This revision is now accepted and ready to land.Sep 18 2020, 4:48 PM
ardumont accepted this revision.Sep 18 2020, 4:56 PM
ardumont added a subscriber: ardumont.

... this also fixes a missed elif instruction ;)

douardda updated this revision to Diff 14096.Sep 21 2020, 10:44 AM

typo (thx anlambert)

This revision was landed with ongoing or failed builds.Sep 21 2020, 10:44 AM
Closed by commit rDSTO8de656451239: Small fix in the graph replayer to prevent a wrong warning (authored by douardda). · Explain Why
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDSTO8de656451239: Small fix in the graph replayer to prevent a wrong warning.
douardda added a commit: rDSTO67ee86b8e03f: Warn about skipped_content sneaking the 'content' topics.
swh-public-ci added a comment.Sep 21 2020, 10:48 AM

Build is green

Patch application report for D3993 (id=14096)

Rebasing onto b0027abc34...

Current branch diff-target is up to date.
Changes applied before test
commit 67ee86b8e03fc56791a27877559be1c4d2553f3d
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Sep 18 16:31:35 2020 +0200

    Warn about skipped_content sneaking the 'content' topics

commit 8de6564512398b86a406668beeac88737ffb8fa2
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Sep 18 16:30:37 2020 +0200

    Small fix in the graph replayer to prevent a wrong warning

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/953/ for more details.

Harbormaster completed remote builds in B15363: Diff 14096.Sep 21 2020, 10:48 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
storage/
6 lines98%
Loading...

Diff 14076

View Options

swh/storage/replay.py

Loading...
About · Developer information · Legal