Paths

Table of Contentst

Declare deposit tool with the correct version
ClosedPublic
Actions

Authored by ardumont on Sep 17 2020, 12:41 PM.

Details

Reviewers

anlambert
vlorentz

Group Reviewers

Reviewers

Commits

rDDEP014f34278f58: Declare deposit tool with the correct version

Summary

This will allow deposit loader to reference metadata with their correct deposit
version.

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15241
Build 23494: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23493: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 17 2020, 12:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 17 2020, 12:41 PM

ardumont mentioned this in D3969: conf/deposit: Explicit deposit api configuration.Sep 17 2020, 12:41 PM

ardumont added inline comments.

swh/deposit/api/__init__.py
11	Wondering again what's the `pkg_resources` pypi package needed here (did not reference any yet in requirements-server.txt). any clues are welcome ;)

Build is green

Patch application report for D3973 (id=14002)

Rebasing onto e5eacbbf8b...

Current branch diff-target is up to date.

Changes applied before test

commit 9e7f0ddc994537d1dc7c6df1ad500f483dbd7ccd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 17 12:36:48 2020 +0200

    Declare deposit tool with the correct version
    
    This will allow deposit loader to reference metadata with their correct deposit
    version.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/92/ for more details.

Harbormaster completed remote builds in B15213: Diff 14002.Sep 17 2020, 12:43 PM

anlambert accepted this revision.Sep 17 2020, 2:07 PM

anlambert added a subscriber: anlambert.

anlambert added inline comments.

swh/deposit/api/__init__.py
11	Looks like it is `setuptools`: https://setuptools.readthedocs.io/en/latest/pkg_resources.html

This revision is now accepted and ready to land.Sep 17 2020, 2:07 PM

ardumont added inline comments.Sep 17 2020, 2:52 PM

swh/deposit/api/__init__.py
11	yeah, thx, forgot about it again. will amend the diff accordingly.

Update requirements-server.txt

Build is green

Patch application report for D3973 (id=14014)

Rebasing onto 0f82840937...

First, rewinding head to replay your work on top of it...
Applying: Declare deposit tool with the correct version

Changes applied before test

commit 4ed9574bd4374e28ea502afd3eddd19cdb08acd8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 17 12:36:48 2020 +0200

    Declare deposit tool with the correct version
    
    This will allow deposit loader to reference metadata with their correct deposit
    version.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/93/ for more details.

Harbormaster completed remote builds in B15241: Diff 14014.Sep 17 2020, 3:11 PM

Could you add a test for version?

vlorentz requested changes to this revision.Sep 17 2020, 3:16 PM

This revision now requires changes to proceed.Sep 17 2020, 3:16 PM

Could you add a test for version?

it's tested already.

Rebase to latest master
Add test on version

Build is green

Patch application report for D3973 (id=14020)

Rebasing onto a12b1195b0...

Current branch diff-target is up to date.

Changes applied before test

commit 014f34278f582b6f43dd8e809b034637de06c824
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Sep 17 12:36:48 2020 +0200

    Declare deposit tool with the correct version
    
    This will allow deposit loader to reference metadata with their correct deposit
    version.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B15276: Diff 14020.Sep 17 2020, 6:05 PM

vlorentz accepted this revision.Sep 17 2020, 6:07 PM

This revision is now accepted and ready to land.Sep 17 2020, 6:07 PM

Closed by commit rDDEP014f34278f58: Declare deposit tool with the correct version (authored by ardumont). · Explain WhySep 17 2020, 6:10 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP014f34278f58: Declare deposit tool with the correct version.