Page MenuHomeSoftware Heritage

swh.core.config: Add types
ClosedPublic

Authored by ardumont on Wed, Sep 16, 3:28 PM.

Details

Test Plan

tox

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Sep 16, 3:28 PM

Build is green

Patch application report for D3966 (id=13959)

Could not rebase; Attempt merge onto 60c535ddee...

Updating 60c535d..b607d05
Fast-forward
 swh/core/config.py            | 135 ++++++++++++++----------------------------
 swh/core/tests/test_config.py |  97 +++++++++++++++++++++++-------
 2 files changed, 122 insertions(+), 110 deletions(-)
Changes applied before test
commit b607d054f2c739143203fb4cdda50efd3ac9dd87
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:26:25 2020 +0200

    swh.core.config: Add types

commit 29414b50cc6f009f7413792d0658c47eaca04a1e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:25:52 2020 +0200

    swh.core.config: Simplify SWHConfig mixin to the actual use
    
    Related to T1532

commit 66ac6ed3aa31a63da3226f2857755f7398721d31
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/47/ for more details.

Build is green

Patch application report for D3966 (id=13961)

Could not rebase; Attempt merge onto 60c535ddee...

Updating 60c535d..dbe36c1
Fast-forward
 swh/core/config.py            | 138 +++++++++++++++---------------------------
 swh/core/tests/test_config.py |  97 ++++++++++++++++++++++-------
 2 files changed, 125 insertions(+), 110 deletions(-)
Changes applied before test
commit dbe36c1be2e13603f09a7c0cdcb90192a5f6cde6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:26:25 2020 +0200

    swh.core.config: Add types

commit 7e3ed44614cf5978fc57f3b5cd6894ab6d3212e7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:25:52 2020 +0200

    swh.core.config: Simplify SWHConfig mixin to the actual use
    
    Related to T1532

commit 66ac6ed3aa31a63da3226f2857755f7398721d31
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/49/ for more details.

Build is green

Patch application report for D3966 (id=13962)

Could not rebase; Attempt merge onto 60c535ddee...

Updating 60c535d..53000c3
Fast-forward
 swh/core/config.py            | 138 +++++++++++++++---------------------------
 swh/core/tests/test_config.py |  97 ++++++++++++++++++++++-------
 2 files changed, 125 insertions(+), 110 deletions(-)
Changes applied before test
commit 53000c3215e4dc1f549a6f0d5dfb1a4eb777bd56
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:26:25 2020 +0200

    swh.core.config: Add types

commit e7b3048844622fe74b83c54682aaa464e34f09b1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:25:52 2020 +0200

    swh.core.config: Simplify SWHConfig mixin to the actual use
    
    Related to T1532

commit 66ac6ed3aa31a63da3226f2857755f7398721d31
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 14:32:19 2020 +0200

    swh.core.config: Drop support for ini configuration file
    
    This is no longer used.
    
    This also adds some types on impacted changed functions.
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/50/ for more details.

vlorentz accepted this revision.Wed, Sep 16, 4:25 PM
This revision is now accepted and ready to land.Wed, Sep 16, 4:25 PM

Build is green

Patch application report for D3966 (id=13968)

Could not rebase; Attempt merge onto 66ac6ed3aa...

Updating 66ac6ed..ab9a3cc
Fast-forward
 swh/core/config.py            | 92 +++++++++++++++----------------------------
 swh/core/tests/test_config.py | 41 +++++++++++++++++++
 2 files changed, 73 insertions(+), 60 deletions(-)
Changes applied before test
commit ab9a3cca7dc045765379cdccb7fa34cf5e86e41f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:26:25 2020 +0200

    swh.core.config: Add types

commit 2934097d81da51a6f9b9423bf710c9a9f3116ae2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:25:52 2020 +0200

    swh.core.config: Simplify SWHConfig mixin to its actual use
    
    Related to T1532

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/53/ for more details.

ardumont updated this revision to Diff 13984.Wed, Sep 16, 5:07 PM

Change commit order

Build is green

Patch application report for D3966 (id=13984)

Rebasing onto 66ac6ed3aa...

Current branch diff-target is up to date.
Changes applied before test
commit 22e77212f1f7704a9d138da12b75304269b1884c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 16 15:26:25 2020 +0200

    swh.core.config: Add types

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/55/ for more details.

This revision was automatically updated to reflect the committed changes.