Differential D3933

internal api: Rename appropriately classes with meaningful names
ClosedPublic
Actions

Authored by ardumont on Sep 11 2020, 5:54 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP61e1b48e4cad: internal api: Rename appropriately classes with meaningful names

Summary

Dropping the redundant SWH or Deposit terms along the way.

Same as D3929 for the internal api part (that api is the one used by the
workers/loaders).

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 11 2020, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 11 2020, 5:54 PM

Build is green

Patch application report for D3933 (id=13861)

Could not rebase; Attempt merge onto ec8dcc1ead...

Updating ec8dcc1e..61e1b48e
Fast-forward
 swh/deposit/api/common.py                        | 18 +++++++-------
 swh/deposit/api/deposit.py                       |  6 ++---
 swh/deposit/api/deposit_content.py               |  6 ++---
 swh/deposit/api/deposit_status.py                |  4 ++--
 swh/deposit/api/deposit_update.py                | 10 ++++----
 swh/deposit/api/private/__init__.py              |  8 +++----
 swh/deposit/api/private/deposit_check.py         |  8 +++----
 swh/deposit/api/private/deposit_list.py          |  4 ++--
 swh/deposit/api/private/deposit_read.py          | 10 ++++----
 swh/deposit/api/private/deposit_update_status.py |  6 ++---
 swh/deposit/api/private/urls.py                  | 30 ++++++++++++------------
 swh/deposit/api/service_document.py              |  6 ++---
 swh/deposit/api/urls.py                          | 26 ++++++++++----------
 swh/deposit/cli/admin.py                         |  4 ++--
 swh/deposit/config.py                            |  2 +-
 swh/deposit/parsers.py                           |  4 ++--
 swh/deposit/tests/api/conftest.py                |  4 ++--
 swh/deposit/tests/conftest.py                    |  6 ++---
 18 files changed, 80 insertions(+), 82 deletions(-)

Changes applied before test

commit 61e1b48e4cadb9603b48b0020a940ffb93f7f386
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 17:40:48 2020 +0200

    internal api: Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH or Deposit terms along the way.

commit cb4b60022d318dfd8803e43c416a2a8ea788ee96
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    public api: Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH or Deposit terms along the way.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/77/ for more details.

Harbormaster completed remote builds in B15085: Diff 13861.Sep 11 2020, 5:56 PM

vlorentz accepted this revision.Sep 14 2020, 9:05 AM

This revision is now accepted and ready to land.Sep 14 2020, 9:05 AM

Closed by commit rDDEP61e1b48e4cad: internal api: Rename appropriately classes with meaningful names (authored by ardumont). · Explain WhySep 14 2020, 10:51 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP61e1b48e4cad: internal api: Rename appropriately classes with meaningful names.