Page MenuHomeSoftware Heritage
Differential D3929

deposit: public api: Rename appropriately classes with meaningful names
ClosedPublic
Actions

Authored by ardumont on Sep 11 2020, 4:06 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDDEPcb4b60022d31: public api: Rename appropriately classes with meaningful names
Summary

There are lots of classes with names like "SWH" or even "Deposit", those are
redundant with the current swh repository about the deposit.

I'd like to clean up a bit prior to actually getting back in that code for the
metadata deposit update.

Test Plan

tox

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15075
Build 23237: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 23236: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 11 2020, 4:06 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 11 2020, 4:06 PM
ardumont retitled this revision from deposit: Rename appropriately classes with meaningfull names to deposit: Rename appropriately classes with meaningful names.Sep 11 2020, 4:07 PM
swh-public-ci added a comment.Sep 11 2020, 4:09 PM

Build is green

Patch application report for D3929 (id=13846)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit d467e2596a9f3803f2673c8f291a906e8041367a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningfull names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/69/ for more details.

Harbormaster completed remote builds in B15071: Diff 13846.Sep 11 2020, 4:09 PM
ardumont updated this revision to Diff 13847.Sep 11 2020, 4:15 PM

Rework commit message

ardumont updated this revision to Diff 13848.Sep 11 2020, 4:16 PM
  • Rename SWHBaseDeposit to APIBase
swh-public-ci added a comment.Sep 11 2020, 4:18 PM

Build is green

Patch application report for D3929 (id=13847)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/70/ for more details.

Harbormaster completed remote builds in B15072: Diff 13847.Sep 11 2020, 4:18 PM
ardumont edited the summary of this revision. (Show Details)Sep 11 2020, 4:18 PM
ardumont updated this revision to Diff 13850.Sep 11 2020, 4:18 PM
  • Rename SWHGetDepositAPI to GetAPI
ardumont updated this revision to Diff 13851.Sep 11 2020, 4:20 PM
  • Rename SWHPostDepositAPI to PostAPI
swh-public-ci added a comment.Sep 11 2020, 4:20 PM

Build is green

Patch application report for D3929 (id=13848)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/71/ for more details.

Harbormaster completed remote builds in B15073: Diff 13848.Sep 11 2020, 4:20 PM
ardumont updated this revision to Diff 13852.Sep 11 2020, 4:22 PM
  • Rename SWHPutDepositAPI to PutAPI
swh-public-ci added a comment.Sep 11 2020, 4:23 PM

Build is green

Patch application report for D3929 (id=13850)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/72/ for more details.

Harbormaster completed remote builds in B15075: Diff 13850.Sep 11 2020, 4:23 PM
swh-public-ci added a comment.Sep 11 2020, 4:25 PM

Build is green

Patch application report for D3929 (id=13851)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit b7c1d6b727dd466dae793ffaf57387e34739ae85
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:21:07 2020 +0200

    Rename SWHPostDepositAPI to PostAPI

commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/73/ for more details.

Harbormaster completed remote builds in B15076: Diff 13851.Sep 11 2020, 4:25 PM
swh-public-ci added a comment.Sep 11 2020, 4:27 PM

Build is green

Patch application report for D3929 (id=13852)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit fe0ac32e6cbeba1ea09ba7f7f8780da970ae5259
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:23:04 2020 +0200

    Rename SWHDeleteDepositAPI to DeleteAPI

commit 81d0e09c93abcfa6d331fb8c2c058d3e08360caa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:22:08 2020 +0200

    Rename SWHPutDepositAPI to PutAPI

commit b7c1d6b727dd466dae793ffaf57387e34739ae85
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:21:07 2020 +0200

    Rename SWHPostDepositAPI to PostAPI

commit 3a9f40af5173eeb56397ea5d52ebe079c66509a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:18:56 2020 +0200

    Rename SWHGetDepositAPI to GetAPI

commit ca0db1cd59c6530c4663d8a7605c9e67ff6a1ad8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:17:08 2020 +0200

    Rename SWHBaseDeposit to APIBase

commit aa0efd36b8d5453445233c2bee10024f603e726f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/74/ for more details.

Harbormaster completed remote builds in B15077: Diff 13852.Sep 11 2020, 4:27 PM
vlorentz accepted this revision.Sep 11 2020, 4:39 PM
vlorentz added a subscriber: vlorentz.

cool!

This revision is now accepted and ready to land.Sep 11 2020, 4:39 PM
ardumont updated this revision to Diff 13858.Sep 11 2020, 5:37 PM

Refactor and unify names so classes start with API...
(also squash commits)

swh-public-ci added a comment.Sep 11 2020, 5:40 PM

Build is green

Patch application report for D3929 (id=13858)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit ac7e8cbb6a905b0574ee67c9084f178aec0ae380
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH prefix along the way

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/75/ for more details.

Harbormaster completed remote builds in B15082: Diff 13858.Sep 11 2020, 5:40 PM
ardumont updated this revision to Diff 13860.Sep 11 2020, 5:45 PM

Forgot to rename to APIGet...

ardumont retitled this revision from deposit: Rename appropriately classes with meaningful names to deposit: public api: Rename appropriately classes with meaningful names.Sep 11 2020, 5:45 PM
ardumont edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Sep 11 2020, 5:48 PM

Build is green

Patch application report for D3929 (id=13860)

Rebasing onto ec8dcc1ead...

Current branch diff-target is up to date.
Changes applied before test
commit cb4b60022d318dfd8803e43c416a2a8ea788ee96
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 11 16:02:35 2020 +0200

    public api: Rename appropriately classes with meaningful names
    
    Dropping the redundant SWH or Deposit terms along the way.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/76/ for more details.

Harbormaster completed remote builds in B15084: Diff 13860.Sep 11 2020, 5:48 PM
ardumont mentioned this in D3933: internal api: Rename appropriately classes with meaningful names.Sep 11 2020, 5:54 PM
Closed by commit rDDEPcb4b60022d31: public api: Rename appropriately classes with meaningful names (authored by ardumont). · Explain WhySep 14 2020, 10:51 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEPcb4b60022d31: public api: Rename appropriately classes with meaningful names.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
deposit/
api/
14 lines90%
Loading...
6 lines40%
Loading...
4 lines88%
Loading...
private/
6 lines97%
Loading...
6 lines92%
Loading...
6 lines98%
Loading...
6 lines100%
Loading...
4 lines100%
Loading...

Diff 13850

View Options

swh/deposit/api/common.py

Loading...
View Options

swh/deposit/api/deposit_content.py

Loading...
View Options

swh/deposit/api/deposit_status.py

Loading...
View Options

swh/deposit/api/private/__init__.py

Loading...
View Options

swh/deposit/api/private/deposit_check.py

Loading...
View Options

swh/deposit/api/private/deposit_read.py

Loading...
View Options

swh/deposit/api/service_document.py

Loading...
View Options

swh/deposit/parsers.py

Loading...
About · Developer information · Legal