Page MenuHomeSoftware Heritage

Rename cli imported from objstorage as objstorage_cli_group
ClosedPublic

Authored by douardda on Thu, Sep 10, 4:20 PM.

Details

Summary

to clarify a bit, especially to make it clearer when used
in the swh.cli.subcommands entrypoint.

Diff Detail

Repository
rDOBJSRPL Content Replayer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Thu, Sep 10, 4:20 PM

Build is green

Patch application report for D3918 (id=13777)

Rebasing onto 8b9db1a0c5...

Current branch diff-target is up to date.
Changes applied before test
commit 48fc343fe36ae7378e1c09e1c66e012c60459b1d
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:06:30 2020 +0200

    Rename cli imported from objstorage as objstorage_group
    
    to clarify a bit, especially to make it clearer when used
    in the swh.cli.subcommands entrypoint.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/4/ for more details.

What about objstorage_cli instead?

What about objstorage_cli instead?

why not, or even objstorage_cli_group

douardda updated this revision to Diff 13842.Fri, Sep 11, 3:22 PM

rename as objstorage_cli_group

Build has FAILED

Patch application report for D3918 (id=13842)

Rebasing onto 8b9db1a0c5...

Current branch diff-target is up to date.
Changes applied before test
commit d4efd38af41ec5a4333f160a81490b34d0a5df02
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:06:30 2020 +0200

    Rename cli imported from objstorage as objstorage_cli_group
    
    to clarify a bit, especially to make it clearer when used
    in the swh.cli.subcommands entrypoint

Link to build: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/5/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/5/console

douardda updated this revision to Diff 13844.Fri, Sep 11, 3:30 PM

also fix test_cli

because mock, again

Build is green

Patch application report for D3918 (id=13844)

Rebasing onto 8b9db1a0c5...

Current branch diff-target is up to date.
Changes applied before test
commit 717d071a0ffa320c47e999d1c291d2bc739c25f9
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:06:30 2020 +0200

    Rename cli imported from objstorage as objstorage_cli_group
    
    to clarify a bit, especially to make it clearer when used
    in the swh.cli.subcommands entrypoint

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/6/ for more details.

douardda retitled this revision from Rename cli imported from objstorage as objstorage_group to Rename cli imported from objstorage as cli_objstorage_group.Fri, Sep 11, 3:33 PM
douardda retitled this revision from Rename cli imported from objstorage as cli_objstorage_group to Rename cli imported from objstorage as objstorage_cli_group.
douardda updated this revision to Diff 13845.Fri, Sep 11, 3:52 PM

forgot setup.py

Build is green

Patch application report for D3918 (id=13845)

Rebasing onto 8b9db1a0c5...

Current branch diff-target is up to date.
Changes applied before test
commit 2c21474347f9b44284a1d2859c4dc71d1a710637
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Sep 10 10:06:30 2020 +0200

    Rename cli imported from objstorage as objstorage_cli_group
    
    to clarify a bit, especially to make it clearer when used
    in the swh.cli.subcommands entrypoint

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/7/ for more details.

vlorentz accepted this revision.Fri, Sep 11, 4:02 PM
This revision is now accepted and ready to land.Fri, Sep 11, 4:02 PM