Differential D3883

algos.diff: Add missed revision_get conversion
ClosedPublic
Actions

Authored by ardumont on Sep 4 2020, 3:37 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDSTO374e01cf3634: algos.diff: Add missed revision_get conversion

Summary

This fixes by doing the minimum required so the diff module still works and fix
[1]. Will release release 0.14.1 asap.

[1] https://forge.softwareheritage.org/harbormaster/unit/view/918517/

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14934
Build 23010: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23009: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 4 2020, 3:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 4 2020, 3:37 PM

anlambert accepted this revision.Sep 4 2020, 3:38 PM

This revision is now accepted and ready to land.Sep 4 2020, 3:38 PM

ardumont mentioned this in D3877: Adapt storage.revision_get calls according to latest api change.Sep 4 2020, 3:38 PM

Build is green

Patch application report for D3883 (id=13705)

Rebasing onto 356eacd763...

Current branch diff-target is up to date.

Changes applied before test

commit 374e01cf3634ee777d52774aae48dd3c230e6c54
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 4 15:35:44 2020 +0200

    algos.diff: Add missed revision_get conversion
    
    This fixes by doing the minimum required so the diff module still works and fix
    [1]. Will release release 0.14.1 asap.
    
    [1] https://forge.softwareheritage.org/harbormaster/unit/view/918517/
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/906/ for more details.

Harbormaster completed remote builds in B14934: Diff 13705.Sep 4 2020, 3:42 PM

Closed by commit rDSTO374e01cf3634: algos.diff: Add missed revision_get conversion (authored by ardumont). · Explain WhySep 4 2020, 3:42 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO374e01cf3634: algos.diff: Add missed revision_get conversion.