Differential D3852

storage*: release_get(...) -> List[Optional[Release]]
ClosedPublic
Actions

Authored by ardumont on Aug 31 2020, 3:42 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDSTOe6fcfb931a7c: storage*: release_get(...) -> List[Optional[Release]]

Summary

Impacts:

D3853: loader-mercurial
D3854: swh-web

$ grep -r "release_get" $SWH_ENVIRONMENT_HOME/*/swh/** | grep -v swh/storage | grep release_get
/home/tony/work/inria/repo/swh/swh-environment/swh-loader-mercurial/swh/loader/mercurial/tests/test_loader.py:    release = loader.storage.release_get([tip_release])
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/common/service.py:    release = _first_element(storage.release_get([sha1_git_bin]))
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/common/service.py:    releases = storage.release_get(sha1_bin_list) or []
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/browse/views/test_origin.py:    release_data = archive_data.release_get(release["target"])
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/browse/views/test_release.py:    release_data = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/browse/test_snapshot_context.py:                rel_data = archive_data.release_get(branch_data["target"])
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/browse/test_snapshot_context.py:    release_data = archive_data.release_get(release_id)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/views/test_release.py:    expected_release = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/views/test_release.py:        expected_release = archive_data.release_get(new_release_id)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/test_utils.py:    release_data = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/test_utils.py:    release_data = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/test_utils.py:    release_data = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/api/test_utils.py:    release_data = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/data.py:                release = next(storage.release_get([branch_data.target]))
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/common/test_identifiers.py:        release_data = archive_data.release_get(releases[release])
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/common/test_identifiers.py:    release_info["name"] = archive_data.release_get(release_info["release"])["name"]
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/common/test_service.py:    assert actual_release == archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/common/test_service.py:    expected = archive_data.release_get(release)
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/conftest.py:    def release_get(self, rel_id):
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/conftest.py:        rel_data = next(self.storage.release_get([rel_id_bytes]))
/home/tony/work/inria/repo/swh/swh-environment/swh-web/swh/web/tests/strategies.py:        lambda s: next(get_tests_data()["storage"].release_get([s])) is None

Related to T645

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14843
Build 22864: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22863: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 31 2020, 3:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2020, 3:42 PM

vlorentz accepted this revision.Aug 31 2020, 3:45 PM

This revision is now accepted and ready to land.Aug 31 2020, 3:45 PM

Build is green

Patch application report for D3852 (id=13611)

Rebasing onto 5afd985ebd...

Current branch diff-target is up to date.

Changes applied before test

commit 57b52aedd9b2e1d89f15dfb64fc1f2388f07cd32
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 31 15:38:12 2020 +0200

    storage*: release_get(...) -> List[Optional[Release]]
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/883/ for more details.

Harbormaster completed remote builds in B14843: Diff 13611.Aug 31 2020, 3:47 PM

ardumont edited the summary of this revision. (Show Details)Aug 31 2020, 3:53 PM

anlambert mentioned this in D3854: swh.web: Adapt to latest storage release_get api change.Sep 1 2020, 1:11 PM

ardumont edited the summary of this revision. (Show Details)Sep 1 2020, 2:15 PM

Rebase

Build is green

Patch application report for D3852 (id=13623)

Rebasing onto e6c17f6ed5...

Current branch diff-target is up to date.

Changes applied before test

commit e6fcfb931a7cf333a9fc3629573cb5d0bab08a88
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 31 15:38:12 2020 +0200

    storage*: release_get(...) -> List[Optional[Release]]
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/889/ for more details.

Harbormaster completed remote builds in B14855: Diff 13623.Sep 1 2020, 2:27 PM

Closed by commit rDSTOe6fcfb931a7c: storage*: release_get(...) -> List[Optional[Release]] (authored by ardumont). · Explain WhySep 1 2020, 2:27 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOe6fcfb931a7c: storage*: release_get(...) -> List[Optional[Release]].