Differential D3836

Tell pytest not to recurse in dotdirs.
ClosedPublic
Actions

Authored by vlorentz on Aug 24 2020, 6:24 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOe8b1b2165223: Tell pytest not to recurse in dotdirs.

Summary

pytest wastes a lot of time in .hypothesis and .git; this commit
excludes them.

Before:

$ time pytest --collect-only > /dev/null
pytest --collect-only > /dev/null 6.93s user 0.51s system 100% cpu 7.425 total

After:

$ time pytest --collect-only > /dev/null
pytest --collect-only > /dev/null 2.39s user 0.10s system 100% cpu 2.475 total

Diff Detail

Repository

rDSTO Storage manager

Branch

pytest-recurse

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14767
Build 22760: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22759: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 24 2020, 6:24 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 24 2020, 6:24 PM

Build is green

Patch application report for D3836 (id=13507)

Rebasing onto cc33dd3596...

First, rewinding head to replay your work on top of it...
Applying: Tell pytest not to recurse in dotdirs.

Changes applied before test

commit 9a9bd1dc0c77f294573f00c7f9d9425e25e266ea
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 24 18:23:27 2020 +0200

    Tell pytest not to recurse in dotdirs.
    
    pytest wastes a lot of time in .hypothesis and .git; this commit
    excludes them.
    
    Before:
    
    $ time pytest --collect-only > /dev/null
    pytest --collect-only > /dev/null  6.93s user 0.51s system 100% cpu 7.425 total
    
    After:
    
    $ time pytest --collect-only > /dev/null
    pytest --collect-only > /dev/null  2.39s user 0.10s system 100% cpu 2.475 total

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/864/ for more details.

Harbormaster completed remote builds in B14767: Diff 13507.Aug 24 2020, 6:29 PM

ardumont accepted this revision.Aug 25 2020, 9:06 AM

This revision is now accepted and ready to land.Aug 25 2020, 9:06 AM

rebase

Build is green

Patch application report for D3836 (id=13511)

Rebasing onto f3870dcd07...

Current branch diff-target is up to date.

Changes applied before test

commit e8b1b2165223b9840790a9844a6dee480b9f5793
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 24 18:23:27 2020 +0200

    Tell pytest not to recurse in dotdirs.
    
    pytest wastes a lot of time in .hypothesis and .git; this commit
    excludes them.
    
    Before:
    
    $ time pytest --collect-only > /dev/null
    pytest --collect-only > /dev/null  6.93s user 0.51s system 100% cpu 7.425 total
    
    After:
    
    $ time pytest --collect-only > /dev/null
    pytest --collect-only > /dev/null  2.39s user 0.10s system 100% cpu 2.475 total

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/867/ for more details.

Harbormaster completed remote builds in B14771: Diff 13511.Aug 25 2020, 10:06 AM

Closed by commit rDSTOe8b1b2165223: Tell pytest not to recurse in dotdirs. (authored by vlorentz). · Explain WhyAug 25 2020, 10:28 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTOe8b1b2165223: Tell pytest not to recurse in dotdirs..