Close T1010
Details
Details
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1302 Build 1646: arc lint + arc unit
Event Timeline
Comment Actions
This looks good ! are the error messages returned to the client as is?
| swh/deposit/api/private/deposit_check.py | ||
|---|---|---|
| 187 | I have a hard time with the error message. Maybe something like this: "the url must be compatible with the client's domain name, its verification has failed" | |
| swh/deposit/tests/api/test_deposit_check.py | ||
| 97 | I have a fail because the list of fields is not in the same order. | |
| swh/deposit/api/private/deposit_check.py | ||
|---|---|---|
| 187 | We don't have a fixed url field key, that's what the 'no url field' tries to convey. What do you think of: | |
| swh/deposit/tests/api/test_deposit_check.py | ||
| 97 | The order is not important so i'll change the way this is tested. I'll also take care of the FIXM (line 76). | |
| swh/deposit/api/private/deposit_check.py | ||
|---|---|---|
| 187 | Better 'At least one url field must be compatible with the client's domain name. The following url fields failed the check'. | |
Comment Actions
@moranegg Grrrr, i have pushed rather too fast (my fingers are faster than my shadow :)
So the diff is closed... (and not updated with the adaptations... T_T)
Here is the commit with the proposed changes though [1].
Please, tell me if you want me to adapt some things.
[1] https://forge.softwareheritage.org/rDDEP95a7aaa0e71ff8990d1d29e0519951b23e04d58f
Cheers,
Comment Actions
No worries, I'm good with the changes.
Also all tests pass on my machine.
When are you deploying?