Page MenuHomeSoftware Heritage

Rename content_get calls to content_get_data
ClosedPublic

Authored by ardumont on Aug 6 2020, 11:48 PM.

Details

Summary

According to the latest change in storage

Test Plan

tox
(failing until storage release > 0.12)

Diff Detail

Unit TestsFailed

TimeTest
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.test_utils
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/test_utils.py:112: in <module> @given(release()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:336: in release
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_content
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_content.py:16: in <module> @given(content()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:88: in content
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_directory
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_directory.py:16: in <module> @given(directory()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:209: in directory
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_identifiers
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_identifiers.py:27: in <module> @given(origin(), content(), directory(), release(), revision(), snapshot()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:255: in origin
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_origin
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_origin.py:344: in <module> @given(origin()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:255: in origin
View Full Test Results (19 Failed)

Event Timeline

Build has FAILED

Patch application report for D3732 (id=13137)

Rebasing onto 8029d68735...

Current branch diff-target is up to date.
Changes applied before test
commit 9b78d4bf4837b9ae948990235e6aac506cf6d4d4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:46:42 2020 +0200

    Rename content_get calls to content_get_data
    
    According to the latest change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/306/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/306/console

Build has FAILED

Patch application report for D3732 (id=13142)

Rebasing onto 8029d68735...

Current branch diff-target is up to date.
Changes applied before test
commit b0656571cab72b58cbbab39790a7203ead95d5ad
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:46:42 2020 +0200

    Rename content_get calls to content_get_data
    
    According to the latest change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/307/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/307/console

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/common/service.py
867–868

let's keep using hashutil.hash_to_hex(hash), unless we explicitly decide to stop using it globally.

This revision is now accepted and ready to land.Aug 7 2020, 9:29 AM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/web/tests/strategies.py
189–191

You need to revert some changes here, the storage instance must be retrieved in the filter implementation (see rDWAPPS29208cecc6f84cbaa93e1f7b631e9f8e9b135d65)

This revision now requires changes to proceed.Aug 7 2020, 11:22 AM
swh/web/tests/strategies.py
189–191

oh, ok, did not know that
thanks for the heads up

swh/web/tests/strategies.py
189–191

or i forgot... (something rings a bell now)

Build has FAILED

Patch application report for D3732 (id=13166)

Rebasing onto 8029d68735...

Current branch diff-target is up to date.
Changes applied before test
commit 78233dbc60d212249592dfbae5882e2d8f73e4f9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:46:42 2020 +0200

    Rename content_get calls to content_get_data
    
    According to the latest change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/311/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/311/console

This revision is now accepted and ready to land.Aug 7 2020, 12:47 PM
swh/web/common/service.py
867–868

oh yeah, forgot about that one ;)
fixing it.

Rework according to missed remark

Build has FAILED

Patch application report for D3732 (id=13169)

Rebasing onto 8029d68735...

Current branch diff-target is up to date.
Changes applied before test
commit 5fb903850c4d6c66925f805a6a541477f9949133
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 23:46:42 2020 +0200

    Rename content_get calls to content_get_data
    
    According to the latest change in storage

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/313/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/313/console

This revision was landed with ongoing or failed builds.Aug 7 2020, 3:02 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D3732 (id=13169)

Rebasing onto 478a7acb46...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-316-D3732.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/316/ for more details.