tasks: Add tests around indexer tasks
ClosedPublic
Actions

Authored by ardumont on Aug 6 2020, 2:30 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCIDX08adca9457a7: tasks: Add tests around indexer tasks

Summary

Preparatory work to rename current "content"-range task to
"content"-partition (as that is what is happening now).

Test Plan

tox

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14379
Build 22104: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22103: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 6 2020, 2:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 6 2020, 2:30 PM

Build is green

Patch application report for D3724 (id=13119)

Rebasing onto 3aedf90c9c...

Current branch diff-target is up to date.

Changes applied before test

commit 89472cdaa61a2330f1b6b7a32e31a80bed7e9f9e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 14:28:35 2020 +0200

    tasks: Add tests around indexer tasks

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/33/ for more details.

Harbormaster completed remote builds in B14379: Diff 13119.Aug 6 2020, 2:31 PM

ardumont added a child revision: D3725: Rename appropriately "partition" indexers and drop "range" mentions.Aug 6 2020, 2:45 PM

I think {"status": "eventful"} is misleading, indexer tasks' returned value doesn't look anywhere near that, does it?

swh/indexer/tests/conftest.py
97	use something other than "loader"

This revision is now accepted and ready to land.Aug 6 2020, 3:00 PM

I think {"status": "eventful"} is misleading, indexer tasks' returned value doesn't look anywhere near that, does it?

nah, they do, well at least initially they did (and some are still returning such values [1]).

[1] https://forge.softwareheritage.org/source/swh-indexer/browse/master/swh/indexer/indexer.py$333

swh/indexer/tests/conftest.py
97	damn, I forgot to update it. thanks.

Fix "loader.yml" to "indexer.yml"

Build is green

Patch application report for D3724 (id=13121)

Rebasing onto 3aedf90c9c...

Current branch diff-target is up to date.

Changes applied before test

commit 08adca9457a7d208f47bf7907ce47070d521d76f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 6 14:28:35 2020 +0200

    tasks: Add tests around indexer tasks

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/35/ for more details.

Harbormaster completed remote builds in B14381: Diff 13121.Aug 6 2020, 3:05 PM

Closed by commit rDCIDX08adca9457a7: tasks: Add tests around indexer tasks (authored by ardumont). · Explain WhyAug 6 2020, 3:09 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX08adca9457a7: tasks: Add tests around indexer tasks.