Page MenuHomeSoftware Heritage
Differential D3708

storage*: origin_get_by_sha1: Drop generator from pgstorage
ClosedPublic
Actions

Authored by ardumont on Aug 5 2020, 9:55 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T2517: Add remaining missing types to swh.storage.interface
Commits
rDSTOc5d63ada5f51: storage*: origin_get_by_sha1: Drop generator from pgstorage
Summary

And simplify its type.

Related to D3698 discussion
Related to T645

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14294
Build 21989: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21988: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 5 2020, 9:55 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 5 2020, 9:55 AM
ardumont mentioned this in D3698: storage*: origin_get_by_sha1: Type remaining existing endpoints.Aug 5 2020, 9:55 AM
swh-public-ci added a comment.Aug 5 2020, 10:03 AM

Build has FAILED

Patch application report for D3708 (id=13050)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..67f10e60
Fast-forward
 swh/storage/cassandra/converters.py |   2 +-
 swh/storage/cassandra/storage.py    | 111 ++++++++++++++++--------
 swh/storage/converters.py           |   6 +-
 swh/storage/filter.py               |  19 ++---
 swh/storage/in_memory.py            | 101 ++++++++++++++--------
 swh/storage/interface.py            | 166 ++++++++++++++++++++----------------
 swh/storage/storage.py              | 107 ++++++++++++++---------
 7 files changed, 312 insertions(+), 200 deletions(-)
Changes applied before test
commit 67f10e60dc868fd13d083d6c26bf0e97fc12908c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 09:46:37 2020 +0200

    storage*: origin_get_by_sha1: Drop generator from pgstorage
    
    And simplify its type
    
    Related to T645

commit a664f682a50bc498df339309723f064bd69c2510
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:33:49 2020 +0200

    storage*: revision_*log: Type remaining existing endpoints
    
    Related to T645

commit 38ee5255b0e0e34a31a7e154a9aac99c9ed16de9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:17:42 2020 +0200

    storage*: revision_get: Type remaining existing endpoints
    
    Related to T645

commit 8b6d18ef2f9e8834906229b16a367c00fb0b95b2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:11:04 2020 +0200

    storage*: revision_missing: Type remaining existing endpoints
    
    Related to T645

commit 9f214bc745ee666071384b47da8a2f6cc7ab65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 23:04:26 2020 +0200

    storage*: directory_entry_get_by_path: Type remaining existing endpoints
    
    Related to T645

commit f9d09527a6ba682c7cdb487de3538fb58fa8b346
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:35:45 2020 +0200

    storage*: directory_ls: Type remaining existing endpoints
    
    Related to T645

commit fd5fd86b11a8dafeb564a3d07624becf57d90672
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:27:45 2020 +0200

    storage*: directory_missing: Type remaining existing endpoints
    
    Related to T645

commit 5d13cd7c545141a632e6e60e485cdc33e451f4e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:07:34 2020 +0200

    storage*: skipped_content_missing: Type remaining existing endpoints
    
    Related to T645

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/687/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/687/console

Harbormaster failed remote builds in B14293: Diff 13050!Aug 5 2020, 10:03 AM
ardumont planned changes to this revision.Aug 5 2020, 10:26 AM

need to fix the build.

ardumont updated this revision to Diff 13051.Aug 5 2020, 10:51 AM

Fix build

swh-public-ci added a comment.Aug 5 2020, 10:56 AM

Build is green

Patch application report for D3708 (id=13051)

Could not rebase; Attempt merge onto a5232b7a7b...

Updating a5232b7a..aab160ae
Fast-forward
 swh/storage/cassandra/converters.py |   2 +-
 swh/storage/cassandra/storage.py    | 111 ++++++++++++++++--------
 swh/storage/converters.py           |   6 +-
 swh/storage/filter.py               |  19 ++---
 swh/storage/in_memory.py            | 101 ++++++++++++++--------
 swh/storage/interface.py            | 166 ++++++++++++++++++++----------------
 swh/storage/storage.py              | 107 ++++++++++++++---------
 swh/storage/tests/test_storage.py   |   6 +-
 8 files changed, 315 insertions(+), 203 deletions(-)
Changes applied before test
commit aab160ae84b609bd7f3da380837b324913a2ba2d
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 09:46:37 2020 +0200

    storage*: origin_get_by_sha1: Drop generator from pgstorage
    
    And simplify its type
    
    Related to T645

commit a664f682a50bc498df339309723f064bd69c2510
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:33:49 2020 +0200

    storage*: revision_*log: Type remaining existing endpoints
    
    Related to T645

commit 38ee5255b0e0e34a31a7e154a9aac99c9ed16de9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:17:42 2020 +0200

    storage*: revision_get: Type remaining existing endpoints
    
    Related to T645

commit 8b6d18ef2f9e8834906229b16a367c00fb0b95b2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:11:04 2020 +0200

    storage*: revision_missing: Type remaining existing endpoints
    
    Related to T645

commit 9f214bc745ee666071384b47da8a2f6cc7ab65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 23:04:26 2020 +0200

    storage*: directory_entry_get_by_path: Type remaining existing endpoints
    
    Related to T645

commit f9d09527a6ba682c7cdb487de3538fb58fa8b346
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:35:45 2020 +0200

    storage*: directory_ls: Type remaining existing endpoints
    
    Related to T645

commit fd5fd86b11a8dafeb564a3d07624becf57d90672
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:27:45 2020 +0200

    storage*: directory_missing: Type remaining existing endpoints
    
    Related to T645

commit 5d13cd7c545141a632e6e60e485cdc33e451f4e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:07:34 2020 +0200

    storage*: skipped_content_missing: Type remaining existing endpoints
    
    Related to T645

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

commit 26ef01563f058bdfe77fcf5d2ca6a897e2894bc8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:24 2020 +0200

    storage*: check_config: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/688/ for more details.

Harbormaster completed remote builds in B14294: Diff 13051.Aug 5 2020, 10:56 AM
ardumont updated this revision to Diff 13053.Aug 5 2020, 10:57 AM

Rebase

swh-public-ci added a comment.Aug 5 2020, 11:06 AM

Build has FAILED

Patch application report for D3708 (id=13053)

Could not rebase; Attempt merge onto 26ef01563f...

Updating 26ef0156..f98724ef
Fast-forward
 swh/storage/cassandra/converters.py |   2 +-
 swh/storage/cassandra/storage.py    | 108 ++++++++++++++++--------
 swh/storage/converters.py           |   6 +-
 swh/storage/filter.py               |  19 ++---
 swh/storage/in_memory.py            |  96 ++++++++++++++-------
 swh/storage/interface.py            | 164 ++++++++++++++++++++----------------
 swh/storage/storage.py              | 105 ++++++++++++++---------
 swh/storage/tests/test_storage.py   |   6 +-
 8 files changed, 308 insertions(+), 198 deletions(-)
Changes applied before test
commit f98724efe0a071cde953715e202029205495802f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 09:46:37 2020 +0200

    storage*: origin_get_by_sha1: Drop generator from pgstorage
    
    And simplify its type
    
    Related to T645

commit a3e39e855ff3712cfcf927caa0f2b8c95dc6b884
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:33:49 2020 +0200

    storage*: revision_*log: Type remaining existing endpoints
    
    Related to T645

commit 38ee5255b0e0e34a31a7e154a9aac99c9ed16de9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:17:42 2020 +0200

    storage*: revision_get: Type remaining existing endpoints
    
    Related to T645

commit 8b6d18ef2f9e8834906229b16a367c00fb0b95b2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:11:04 2020 +0200

    storage*: revision_missing: Type remaining existing endpoints
    
    Related to T645

commit 9f214bc745ee666071384b47da8a2f6cc7ab65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 23:04:26 2020 +0200

    storage*: directory_entry_get_by_path: Type remaining existing endpoints
    
    Related to T645

commit f9d09527a6ba682c7cdb487de3538fb58fa8b346
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:35:45 2020 +0200

    storage*: directory_ls: Type remaining existing endpoints
    
    Related to T645

commit fd5fd86b11a8dafeb564a3d07624becf57d90672
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:27:45 2020 +0200

    storage*: directory_missing: Type remaining existing endpoints
    
    Related to T645

commit 5d13cd7c545141a632e6e60e485cdc33e451f4e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:07:34 2020 +0200

    storage*: skipped_content_missing: Type remaining existing endpoints
    
    Related to T645

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

commit 25ebc48198d665cc3bb71c96a8ae54775ddf38a8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:42:12 2020 +0200

    storage*: content_update: Type remaining existing endpoints
    
    Related to T645

commit c32e224d23996705a6ca969696cc4715598ed796
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:59:46 2020 +0200

    storage*: origin_get_by_sha1: Type remaining existing endpoints
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/690/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/690/console

Harbormaster failed remote builds in B14296: Diff 13053!Aug 5 2020, 11:06 AM
ardumont updated this revision to Diff 13056.Aug 5 2020, 11:13 AM

Rebase

swh-public-ci added a comment.Aug 5 2020, 11:22 AM

Build is green

Patch application report for D3708 (id=13056)

Could not rebase; Attempt merge onto 25ebc48198...

Updating 25ebc481..c5d63ada
Fast-forward
 swh/storage/cassandra/converters.py |   2 +-
 swh/storage/cassandra/storage.py    | 100 +++++++++++++++--------
 swh/storage/converters.py           |   6 +-
 swh/storage/filter.py               |  19 +++--
 swh/storage/in_memory.py            |  96 ++++++++++++++--------
 swh/storage/interface.py            | 156 ++++++++++++++++++++----------------
 swh/storage/storage.py              |  95 +++++++++++++---------
 swh/storage/tests/test_storage.py   |   6 +-
 8 files changed, 289 insertions(+), 191 deletions(-)
Changes applied before test
commit c5d63ada5f51e2b4c493fc7e105fbb776552ccd6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 09:46:37 2020 +0200

    storage*: origin_get_by_sha1: Drop generator from pgstorage
    
    And simplify its type
    
    Related to T645

commit 760cbf6db540f9c22a19b9f1a76fc05ceeedb7df
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:33:49 2020 +0200

    storage*: revision_*log: Type remaining existing endpoints
    
    Related to T645

commit 38ee5255b0e0e34a31a7e154a9aac99c9ed16de9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:17:42 2020 +0200

    storage*: revision_get: Type remaining existing endpoints
    
    Related to T645

commit 8b6d18ef2f9e8834906229b16a367c00fb0b95b2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Aug 5 08:11:04 2020 +0200

    storage*: revision_missing: Type remaining existing endpoints
    
    Related to T645

commit 9f214bc745ee666071384b47da8a2f6cc7ab65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 23:04:26 2020 +0200

    storage*: directory_entry_get_by_path: Type remaining existing endpoints
    
    Related to T645

commit f9d09527a6ba682c7cdb487de3538fb58fa8b346
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:35:45 2020 +0200

    storage*: directory_ls: Type remaining existing endpoints
    
    Related to T645

commit fd5fd86b11a8dafeb564a3d07624becf57d90672
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:27:45 2020 +0200

    storage*: directory_missing: Type remaining existing endpoints
    
    Related to T645

commit 5d13cd7c545141a632e6e60e485cdc33e451f4e2
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 22:07:34 2020 +0200

    storage*: skipped_content_missing: Type remaining existing endpoints
    
    Related to T645

commit 1a2aa70c687cbdac7655257ac3e6e572c8da43b4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:57:37 2020 +0200

    storage*: content_missing_per_sha1_git: Type remaining existing endpoints
    
    Related to T645

commit 15e48633a6a7beeccd233a38cdd456070fb4ae07
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:55:39 2020 +0200

    storage*: content_missing_per_sha1: Type remaining existing endpoints
    
    Related to T645

commit b62afbbbdd95aaa91163c8907fa7237231d7c3a6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:13:43 2020 +0200

    storage*: content_missing: Unify and type remaining existing endpoints
    
    This updates the docstrings as well
    
    Related to T645

commit d6f26e45e9a62894ab2b888a15f8a4417c3b2ce0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 18:06:06 2020 +0200

    storage*: content_get_partition: Type remaining existing endpoints
    
    Related to T645

commit 864473370acdfd5acaf9afbfea9d16745b3c102f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:56:39 2020 +0200

    storage*: content_get_range: Type remaining existing endpoints
    
    Related to T645

commit c6da28289ec4f1be1eb1c1e78d561b8cc8dac937
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 4 17:45:31 2020 +0200

    storage*: content_get: Type remaining existing endpoints
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/692/ for more details.

Harbormaster completed remote builds in B14299: Diff 13056.Aug 5 2020, 11:22 AM
vlorentz accepted this revision.Aug 5 2020, 12:47 PM
This revision is now accepted and ready to land.Aug 5 2020, 12:47 PM
Closed by commit rDSTOc5d63ada5f51: storage*: origin_get_by_sha1: Drop generator from pgstorage (authored by ardumont). · Explain WhyAug 5 2020, 12:49 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSTOc5d63ada5f51: storage*: origin_get_by_sha1: Drop generator from pgstorage.
ardumont added a task: T2517: Add remaining missing types to swh.storage.interface.Aug 5 2020, 1:12 PM
ardumont removed a task: T645: Type swh-storage endpoints with swh.model objects.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
storage/
cassandra/
4 lines95%
Loading...
7 lines98%
Loading...
8 lines69%
Loading...
13 lines94%
Loading...
tests/
6 lines99%
Loading...

Diff 13051

View Options

swh/storage/cassandra/storage.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/interface.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal