Page MenuHomeSoftware Heritage

templates: Fix browsed object metadata availability from javascript
ClosedPublic

Authored by anlambert on Aug 4 2020, 1:22 PM.

Details

Summary

A regression was introduced in 8e0fa87b22d7 making browsed object metadata no more
available from javascript for anonymous users.

As a consequence, some Jupyter notebooks rendering were broken as some images could
not be loaded anymore (see https://archive.softwareheritage.org/browse/origin/content/?origin_url=https://github.com/annotation/tutorials&path=uruk/imagery.ipynb
for instance)

Test Plan

A cypress test has been added to check metadata availablity from javascript.

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-js-metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14257
Build 21922: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 21921: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 4 2020, 1:28 PM

Build has FAILED

Patch application report for D3695 (id=13015)

Rebasing onto 325d820f62...

Current branch diff-target is up to date.
Changes applied before test
commit 64c22747fdf70bd20ee84a528e794e09a873f0cd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Aug 4 13:16:07 2020 +0200

    templates: Fix browsed object metadata availability from javascript
    
    That regression was introduced in 8e0fa87b22d7.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/296/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/296/console

Build is green

Patch application report for D3695 (id=13015)

Rebasing onto 325d820f62...

Current branch diff-target is up to date.
Changes applied before test
commit 64c22747fdf70bd20ee84a528e794e09a873f0cd
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Aug 4 13:16:07 2020 +0200

    templates: Fix browsed object metadata availability from javascript
    
    That regression was introduced in 8e0fa87b22d7.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/297/ for more details.

Rebase and upgrade js dependencies

Build is green

Patch application report for D3695 (id=13022)

Rebasing onto 8f1e003bc7...

Current branch diff-target is up to date.
Changes applied before test
commit 957fd2fdfe6c7647a2174d0785d9682c4edc1159
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Aug 4 13:41:25 2020 +0200

    package.json: Upgrade dependencies

commit b913946250542abfb452b0c1a79bbcddd5b75ebb
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Tue Aug 4 13:16:07 2020 +0200

    templates: Fix browsed object metadata availability from javascript
    
    That regression was introduced in 8e0fa87b22d7.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/302/ for more details.