For consistency with RawExtrinsicMetadata.
Depends on D3663.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDSTO0eb309e02dd3: Rename argument 'object_type' of raw_extrinsic_metadata_get to 'type'.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- raw_extrinsic_metadata_get-type
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14138 Build 21721: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 21720: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 1,960 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_storage.TestStorage::test_origin_visit_status_get_random self = <swh.storage.tests.test_storage.TestStorage object at 0x7fa9c22310b8>
swh_storage = <swh.storage.storage.Storage object at 0x7fa9c213f6a0>
sample_data = <swh.storage.tests.storage_data.StorageData object at 0x7fa9c3bf0320>
| |
| 8 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content | |
| 3 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin | |
| 6 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_origin_visit | |
| 4 ms | Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_revision | |
| View Full Test Results (1 Failed · 752 Passed · 17 Skipped) |
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3666 (id=12900)
Could not rebase; Attempt merge onto cf9f44e805...
Updating cf9f44e8..0eb309e0 Fast-forward swh/storage/backfill.py | 43 +++++++++++++- swh/storage/cassandra/storage.py | 32 +++++----- swh/storage/converters.py | 38 ++++++++++++ swh/storage/db.py | 48 ++++++++------- swh/storage/in_memory.py | 46 +++++++-------- swh/storage/interface.py | 13 ++--- swh/storage/replay.py | 8 ++- swh/storage/storage.py | 82 ++++++++------------------ swh/storage/tests/test_backfill.py | 5 +- swh/storage/tests/test_kafka_writer.py | 9 +++ swh/storage/tests/test_replay.py | 9 ++- swh/storage/tests/test_retry.py | 4 +- swh/storage/tests/test_storage.py | 104 ++++++++++++++++----------------- 13 files changed, 253 insertions(+), 188 deletions(-)
Changes applied before test
commit 0eb309e02dd38022ed3af1facb291b1a31f4b7e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jul 31 13:00:42 2020 +0200
Rename argument 'object_type' of raw_extrinsic_metadata_get to 'type'.
For consistency with RawExtrinsicMetadata.
commit b385c7994ece2cdb52b813e93b79dd385c2bee2a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jul 31 12:30:31 2020 +0200
Make raw_extrinsic_metadata_get return PagedResult instead of Dict.
commit df943ec25cf91c0417c23a7376d40414a429db7d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Fri Jul 31 10:11:57 2020 +0200
pg: Rewrite _origin_query to force the query planner to filter on URLs before filtering on visits.
URL filters usually have a few matches and use the index; whereas filtering
on visits requires to scan the entire origin table first.
This makes the query considerably faster.
Credit for the idea goes to @olasd.
commit 0c5a8e274af2aae42cdaedf3b462a9db0fdbf177
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 30 19:39:41 2020 +0200
Add support for metadata-related object types to the backfiller and replayer.
Existing tests automatically test them, using data from swh.journal.tests.
commit 24bc51dfff6c2fd825534a6dac23ff6a7e02faa0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Jul 30 19:33:14 2020 +0200
test_replay: update for swh.journal 0.4.1.
DUPLICATE_CONTENTS now contains BaseModel objects.Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/638/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/638/console