Differential D3661

common/service: Migrate origin_search to latest apis change
ClosedPublic
Actions

Authored by ardumont on Jul 30 2020, 10:56 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T645: Type swh-storage endpoints with swh.model objects

Commits

rDWAPPSddfb658d2502: common/service: Migrate origin_search to latest apis change

Summary

Related to T645

Test Plan

tox
(failing until swh.storage > 0.11.6 and swh.search > 0.0.4 releases)

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 30 2020, 10:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 30 2020, 10:56 PM

Build has FAILED

Patch application report for D3661 (id=12882)

Rebasing onto b712b2679e...

Current branch diff-target is up to date.

Changes applied before test

commit 6ae2352f7a3277647fc3622a6cac1bceccf647f0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 30 22:55:35 2020 +0200

    common/service: Migrate origin_search to latest apis change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/286/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/286/console

Harbormaster failed remote builds in B14119: Diff 12882!Jul 30 2020, 11:10 PM

ardumont mentioned this in D3657: search*: Type origin_search(...) -> PagedResult[Dict].Jul 31 2020, 10:08 AM

vlorentz accepted this revision.Jul 31 2020, 11:36 AM

This revision is now accepted and ready to land.Jul 31 2020, 11:36 AM

ardumont edited the test plan for this revision. (Show Details)Jul 31 2020, 2:14 PM

Adapt according to latest change in swh-search (should still fail as release
from storage is missing)

Build has FAILED

Patch application report for D3661 (id=12915)

Rebasing onto b712b2679e...

Current branch diff-target is up to date.

Changes applied before test

commit ddfb658d250236ad02c173ba4c018f02992550f3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 30 22:55:35 2020 +0200

    common/service: Migrate origin_search to latest apis change
    
    Related to T645

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/287/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/287/console

Harbormaster failed remote builds in B14153: Diff 12915!Jul 31 2020, 2:30 PM

Build is green

Patch application report for D3661 (id=12915)

Rebasing onto b712b2679e...

Current branch diff-target is up to date.

Changes applied before test

commit ddfb658d250236ad02c173ba4c018f02992550f3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 30 22:55:35 2020 +0200

    common/service: Migrate origin_search to latest apis change
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/288/ for more details.

Harbormaster completed remote builds in B14153: Diff 12915.Jul 31 2020, 3:32 PM

Closed by commit rDWAPPSddfb658d2502: common/service: Migrate origin_search to latest apis change (authored by ardumont). · Explain WhyJul 31 2020, 3:36 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPSddfb658d2502: common/service: Migrate origin_search to latest apis change.