Page MenuHomeSoftware Heritage
Differential D3622

storage*: origin_visit_find_by_date -> Optional[OriginVisit]
ClosedPublic
Actions

Authored by ardumont on Jul 27 2020, 12:49 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T645: Type swh-storage endpoints with swh.model objects
Commits
rDSTO57e305e03b66: storage*: origin_visit_find_by_date -> Optional[OriginVisit]
Summary

No impact as it's apparently unused.

$ grep -r 'origin_visit_find_by_date(' */swh/** | grep -v "swh-storage"

Related to T645

Test Plan

tox is still happy

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 27 2020, 12:49 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 27 2020, 12:49 PM
vlorentz accepted this revision.Jul 27 2020, 12:52 PM
This revision is now accepted and ready to land.Jul 27 2020, 12:52 PM
swh-public-ci added a comment.Jul 27 2020, 12:57 PM

Build is green

Patch application report for D3622 (id=12752)

Rebasing onto b31c30491e...

Current branch diff-target is up to date.
Changes applied before test
commit 57e305e03b66508a702f5e177b84e84640ef855e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jul 27 12:44:37 2020 +0200

    storage*: origin_visit_find_by_date -> Optional[OriginVisit]
    
    Related to T645

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/567/ for more details.

Harbormaster completed remote builds in B13982: Diff 12752.Jul 27 2020, 12:57 PM
Closed by commit rDSTO57e305e03b66: storage*: origin_visit_find_by_date -> Optional[OriginVisit] (authored by ardumont). · Explain WhyJul 27 2020, 1:13 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSTO57e305e03b66: storage*: origin_visit_find_by_date -> Optional[OriginVisit].

Revision Contents
Changeset List

PathSize
swh/
storage/
cassandra/
6 lines
6 lines
4 lines
12 lines
tests/
13 lines

Diff 12753

View Options

swh/storage/cassandra/storage.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/interface.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal